Skip to content

fix(validation): flag empty or missing package name as invalid (#850, #885) #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShivanshhhG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(validation): flag empty or missing package name as invalid (#850, #885) #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/spdx_tools/spdx/validation/package_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ def validate_package(
spdx_id=package.spdx_id, element_type=SpdxElementType.PACKAGE, full_element=package
)

if package.name is None or not str(package.name).strip():
validation_messages.append(ValidationMessage("package name is mandatory and cannot be empty", context))

download_location = package.download_location
if isinstance(download_location, str):
for message in validate_download_location(download_location):
Expand Down
12 changes: 12 additions & 0 deletions tests/spdx/validation/test_package_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,15 @@ def test_v2_2mandatory_fields():
expected = [ValidationMessage(f"{field} is mandatory in SPDX-2.2", context) for field in mandatory_fields]

TestCase().assertCountEqual(validation_messages, expected)


@pytest.mark.parametrize("invalid_name", ["", " ", "\t\n"])
def test_invalid_package_name(invalid_name):
package = package_fixture(name=invalid_name)
validation_messages = validate_package(package, "SPDX-2.3")

context = ValidationContext(spdx_id=package.spdx_id, element_type=SpdxElementType.PACKAGE, full_element=package)
expected = [ValidationMessage("package name is mandatory and cannot be empty", context)]

assert validation_messages == expected