Skip to content

Keep raising the bar on code coverage - #2989

Merged
jviotti merged 2 commits into
mainfrom
cov-more
Oct 11, 2026
Merged

jviotti merged 2 commits into
mainfrom
cov-more

Conversation

@jviotti

@jviotti jviotti commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

View guided diff

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 77 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread test/uri/uri_user_info_test.cc Outdated
Comment thread test/numeric/numeric_decimal_test.cc Outdated
Comment thread test/markdown/markdown_tables_test.cc Outdated
Comment thread test/yaml/yaml_parse_test.cc Outdated
Comment thread test/yaml/yaml_stringify_test.cc Outdated
Comment thread test/jsonld/jsonld_expand_test.cc Outdated
Comment thread test/crypto/crypto_sign_test.cc
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Benchmark linux/llvm

Measured against main at cd68e0c.

32 slower, 5 faster, 75 within 5%.

Benchmark main This branch Change
Regex_Period_Plus 1.26 ns 1.67 ns +33.2%
JSON_Array_Of_Strings_Unique_Colliding_256 94.64 us 124.84 us +31.9%
Schema_Frame_OMC_References 4.82 ms 5.83 ms +20.9%
Schema_Frame_OMC_Pointers 9.70 ms 11.49 ms +18.5%
JSON_String_Key_Hash_100 3.64 ns 4.23 ns +16.3%
Pointer_Walker_Schema_ISO_Language 767.18 us 891.55 us +16.2%
Pointer_Push_Back_Pointer_To_Weak_Pointer 69.83 ns 80.89 ns +15.8%
Schema_Tracker_ISO_Language 2.17 ms 2.48 ms +13.9%
OpenAPI_Format_Synthetic_3_1 29.83 ms 33.58 ms +12.6%
Schema_Tracker_ISO_Language_To_JSON 8.68 ms 9.70 ms +11.8%
JSON_Array_Of_Integers_Unique_256 2.04 us 2.27 us +11.4%
URITemplateRouter_Match 71.53 ns 79.51 ns +11.1%
JSON_Equality_Helm_Chart_Lock 79.21 ns 87.47 ns +10.4%
Schema_Frame_OMC_Locations 4.26 ms 4.68 ms +9.9%
JSON_Array_Of_Objects_Unique 213.66 ns 232.84 ns +9.0%
URITemplateRouter_Create 10.83 us 11.71 us +8.1%
JSON_String_Key_Hash_10 1.13 ns 1.21 ns +7.2%
Regex_Period_Md_Dollar 14.26 ns 15.25 ns +6.9%
JSON_String_Equal_10 2.51 ns 2.69 ns +6.8%
URITemplateRouterView_Match 68.16 ns 72.79 ns +6.8%
URITemplateRouter_Match_BasePath 86.33 ns 91.87 ns +6.4%
Schema_Frame_ISO_Language_Locations 26.51 ms 28.21 ms +6.4%
JSON_Divisible_By_Decimal 162.66 ns 172.66 ns +6.2%
JSON_Parse_Nested_Containers 17.18 us 18.21 us +6.0%
Pointer_Untracked_Deeply_Nested 675.97 us 714.77 us +5.7%
JSONLD_Catalog_Materialize 1.82 ms 1.93 ms +5.6%
Schema_Frame_WoT_References 1.11 ms 1.16 ms +5.3%
JSON_Object_At_Last_Key_32 7.52 ns 7.91 ns +5.2%
JOSE_VerifySignature_RS256 30.74 us 32.33 us +5.2%
Pointer_Position_Tracker_Get_Deeply_Nested 402.65 ns 423.38 ns +5.1%
URITemplateRouterView_Restore 6.92 us 7.27 us +5.1%
Pointer_Object_Traverse 14.32 ns 15.03 ns +5.0%
Schema_Frame_KrakenD_References 9.98 ms 9.43 ms -5.5%
JSONL_Parse_Large 5.29 ms 4.98 ms -5.7%
JSON_String_Fast_Hash_10 1.25 ns 1.17 ns -5.9%
JSON_PropertySet_Contains 28.08 ns 25.31 ns -9.8%
Regex_Caret_Period_Asterisk_Dollar 1.65 ns 1.21 ns -26.7%
All 112 benchmarks
Benchmark main This branch Change
Regex_Lower_S_Or_Upper_S_Asterisk 1.19 ns 1.21 ns +1.9%
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.45 ns 1.44 ns -0.7%
Regex_Period_Asterisk 1.43 ns 1.44 ns +0.9%
Regex_Group_Period_Asterisk_Group 1.19 ns 1.20 ns +1.2%
Regex_Period_Plus 1.26 ns 1.67 ns +33.2%
Regex_Period 1.44 ns 1.45 ns +0.9%
Regex_Caret_Period_Plus_Dollar 1.49 ns 1.48 ns -0.7%
Regex_Caret_Group_Period_Plus_Group_Dollar 1.27 ns 1.25 ns -1.8%
Regex_Caret_Period_Asterisk_Dollar 1.65 ns 1.21 ns -26.7%
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.42 ns 1.44 ns +1.6%
Regex_Caret_X_Hyphen 2.62 ns 2.66 ns +1.6%
Regex_Period_Md_Dollar 14.26 ns 15.25 ns +6.9%
Regex_Caret_Slash_Period_Asterisk 2.39 ns 2.39 ns -0.0%
Regex_Caret_Period_Range_Dollar 1.69 ns 1.67 ns -1.2%
Regex_Nested_Backtrack 20.56 ns 21.49 ns +4.5%
JSON_Array_Of_Objects_Unique 213.66 ns 232.84 ns +9.0%
JSON_Array_Of_Integers_Unique_256 2.04 us 2.27 us +11.4%
JSON_Array_Of_Strings_Unique_Colliding_256 94.64 us 124.84 us +31.9%
JSON_Parse_1 2.42 us 2.31 us -4.6%
JSON_Parse_Real 2.45 us 2.40 us -2.3%
JSON_Parse_Real_Inexact 2.09 us 2.12 us +1.3%
JSON_Parse_Decimal 3.93 us 3.94 us +0.2%
JSON_Parse_Schema_ISO_Language 1.75 ms 1.75 ms -0.3%
JSON_Parse_Integer 2.02 us 1.97 us -2.2%
JSON_Parse_String_NonSSO_Plain 1.72 us 1.68 us -2.4%
JSON_Parse_String_SSO_Plain 1.50 us 1.47 us -1.5%
JSON_Parse_String_Escape_Heavy 6.81 us 6.67 us -2.0%
JSON_Parse_Object_Short_Keys 3.84 us 3.90 us +1.4%
JSON_Parse_Object_Scalar_Properties 1.93 us 1.98 us +2.6%
JSON_Parse_Object_Array_Properties 2.80 us 2.86 us +2.1%
JSON_Parse_Object_Object_Properties 2.76 us 2.84 us +2.8%
JSON_Parse_Nested_Containers 17.18 us 18.21 us +6.0%
JSON_Fast_Hash_Helm_Chart_Lock 34.43 ns 34.55 ns +0.3%
JSON_Equality_Helm_Chart_Lock 79.21 ns 87.47 ns +10.4%
JSON_String_Equal_10 2.51 ns 2.69 ns +6.8%
JSON_String_Equal_100 3.31 ns 3.44 ns +3.7%
JSON_String_Equal_Small_By_Perfect_Hash_10 0.48 ns 0.48 ns -1.1%
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 7.17 ns 6.97 ns -2.7%
JSON_String_Fast_Hash_10 1.25 ns 1.17 ns -5.9%
JSON_String_Fast_Hash_100 1.26 ns 1.21 ns -3.6%
JSON_String_Key_Hash_10 1.13 ns 1.21 ns +7.2%
JSON_String_Key_Hash_100 3.64 ns 4.23 ns +16.3%
JSON_Object_Defines_Miss_Same_Length 1.94 ns 1.96 ns +1.1%
JSON_Object_Defines_Miss_Too_Small 1.41 ns 1.41 ns -0.0%
JSON_Object_Defines_Miss_Too_Large 1.40 ns 1.42 ns +1.5%
JSON_From_String_Copy 5.73 ns 5.87 ns +2.5%
JSON_From_String_Temporary 5.26 ns 5.28 ns +0.4%
JSON_Number_To_Double 8.11 ns 8.51 ns +5.0%
JSON_Object_At_Last_Key_8 2.13 ns 2.24 ns +4.9%
JSON_Object_At_Last_Key_32 7.52 ns 7.91 ns +5.2%
JSON_Object_At_Last_Key_128 42.00 ns 43.74 ns +4.1%
JSON_Object_At_Last_Key_512 149.75 ns 150.64 ns +0.6%
JSON_Divisible_By_Decimal 162.66 ns 172.66 ns +6.2%
JSON_PropertySet_Contains 28.08 ns 25.31 ns -9.8%
JSON_PropertySet_Filter_Object_Properties 20.65 ns 20.75 ns +0.5%
JSON_PropertySet_Insert 282.88 ns 288.67 ns +2.0%
JSON_Stringify_Schema_Web_Of_Things 32.45 us 32.75 us +0.9%
JSON_Prettify_Schema_Web_Of_Things 90.58 us 92.57 us +2.2%
Pointer_Object_Traverse 14.32 ns 15.03 ns +5.0%
Pointer_Object_Try_Traverse 16.53 ns 17.25 ns +4.4%
Pointer_Push_Back_Pointer_To_Weak_Pointer 69.83 ns 80.89 ns +15.8%
Pointer_Walker_Schema_ISO_Language 767.18 us 891.55 us +16.2%
Pointer_Untracked_Deeply_Nested 675.97 us 714.77 us +5.7%
Pointer_Tracked_Deeply_Nested 841.07 us 876.62 us +4.2%
Pointer_Position_Tracker_Get_Deeply_Nested 402.65 ns 423.38 ns +5.1%
Schema_Tracker_ISO_Language 2.17 ms 2.48 ms +13.9%
Schema_Tracker_ISO_Language_To_JSON 8.68 ms 9.70 ms +11.8%
Schema_Frame_WoT_References 1.11 ms 1.16 ms +5.3%
Schema_Frame_OMC_References 4.82 ms 5.83 ms +20.9%
Schema_Frame_OMC_Pointers 9.70 ms 11.49 ms +18.5%
Schema_Frame_OMC_Locations 4.26 ms 4.68 ms +9.9%
Schema_Frame_ISO_Language_Locations 26.51 ms 28.21 ms +6.4%
Schema_Frame_ISO_Language_Root 170.25 ns 163.30 ns -4.1%
Schema_Frame_KrakenD_References 9.98 ms 9.43 ms -5.5%
Schema_Frame_KrakenD_Reachable 87.47 ms 84.78 ms -3.1%
Schema_Frame_ISO_Language_Locations_To_JSON 21.37 ms 21.34 ms -0.1%
Schema_Frame_Many_Resources_References 70.71 ms 72.90 ms +3.1%
Schema_Frame_Deeply_Nested_References 7.08 ms 6.82 ms -3.6%
Schema_Format_ISO_Language 31.55 ms 32.73 ms +3.7%
Schema_Bundle_Meta_2020_12 275.95 us 285.11 us +3.3%
Schema_Bundle_Many_Remotes_With_Fragments 3.42 ms 3.50 ms +2.4%
OpenAPI_Frame_GSMTasks_3_0 106.35 ms 106.61 ms +0.2%
OpenAPI_Format_Synthetic_3_1 29.83 ms 33.58 ms +12.6%
JSONPath_Descendant_Filter_Nested 972.20 ns 1.02 us +4.8%
URITemplateRouter_Create 10.83 us 11.71 us +8.1%
URITemplateRouter_Match 71.53 ns 79.51 ns +11.1%
URITemplateRouterView_Restore 6.92 us 7.27 us +5.1%
URITemplateRouterView_Match 68.16 ns 72.79 ns +6.8%
URITemplateRouterView_Arguments 302.87 ns 300.10 ns -0.9%
URITemplateRouter_Match_BasePath 86.33 ns 91.87 ns +6.4%
URITemplateRouterView_Match_BasePath 78.78 ns 80.54 ns +2.2%
JSONL_Parse_Large 5.29 ms 4.98 ms -5.7%
JSONL_Parse_Large_GZIP 5.36 ms 5.10 ms -4.8%
JSONLD_Catalog_Annotation_List_Populate 339.51 us 328.19 us -3.3%
JSONLD_Catalog_Materialize 1.82 ms 1.93 ms +5.6%
HTML_Build_Table_100000 18.74 ms 18.87 ms +0.7%
HTML_Render_Table_100000 1.64 ms 1.69 ms +3.0%
Markdown_To_HTML_Realistic_Document 2.14 ms 2.21 ms +3.1%
Markdown_To_HTML_Pathological 7.42 ms 7.59 ms +2.4%
Markdown_To_HTML_Short_Descriptions 287.01 ns 284.20 ns -1.0%
GZIP_Compress_ISO_Language_Set_3_Locations 23.21 ms 23.34 ms +0.6%
GZIP_Decompress_ISO_Language_Set_3_Locations 3.61 ms 3.58 ms -1.0%
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations 4.71 ms 4.54 ms -3.5%
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations 5.28 ms 5.28 ms -0.0%
GZIP_Compress_ISO_Language_Set_3_Schema 1.50 ms 1.56 ms +4.2%
GZIP_Decompress_ISO_Language_Set_3_Schema 288.81 us 296.26 us +2.6%
JOSE_VerifySignature_RS256 30.74 us 32.33 us +5.2%
JOSE_VerifySignature_ES512 1.16 ms 1.14 ms -1.7%
Crypto_CRC32_Large_JSONL 74.90 us 76.55 us +2.2%
Crypto_AES_GCM_Encrypt_128_1KB 20.93 us 21.01 us +0.4%
Crypto_AES_GCM_Decrypt_128_1KB 20.94 us 21.04 us +0.5%
Crypto_AES_GCM_Encrypt_256_1KB 26.08 us 26.29 us +0.8%

@augmentcode

augmentcode Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Raises coverage standards through additional regression tests and removal of unreachable paths.

  • Raises minimum line and region coverage from 95% to 97%.
  • Adds a separate 92% branch-coverage floor while retaining full function coverage.
  • Checks all three count-based metric totals without relying on rounded percentages.
  • Replaces unreachable defensive paths with assertions or std::unreachable() and removes redundant enum fallbacks.
  • Simplifies Markdown parsing and rendering around normalized LF line endings.
  • Allows closing an empty HTML writer and rejects userinfo on relative-path URIs.
  • Rejects implicit YAML alias mapping keys without a colon.
  • Adds tests for key self-moves, large gzip streams, decimal arithmetic, and HTTP/authentication edge cases.
  • Expands JSON-LD, schema/OpenAPI bundling, Markdown, and YAML round-trip regression coverage.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Benchmark linux/gcc

Measured against main at cd68e0c.

10 slower, 11 faster, 91 within 5%.

Benchmark main This branch Change
Regex_Period_Md_Dollar 30.73 ns 38.06 ns +23.9%
JSON_Array_Of_Strings_Unique_Colliding_256 199.71 us 242.61 us +21.5%
JSON_From_String_Temporary 8.31 ns 9.16 ns +10.2%
Regex_Nested_Backtrack 39.43 ns 43.43 ns +10.1%
Regex_Caret_Period_Range_Dollar 3.34 ns 3.65 ns +9.3%
JSON_Parse_String_NonSSO_Plain 3.65 us 3.93 us +7.9%
JSON_PropertySet_Insert 461.82 ns 496.15 ns +7.4%
URITemplateRouterView_Match_BasePath 147.57 ns 156.51 ns +6.1%
URITemplateRouterView_Match 129.04 ns 136.28 ns +5.6%
JSON_Parse_Real_Inexact 5.79 us 6.10 us +5.4%
JSON_Fast_Hash_Helm_Chart_Lock 75.45 ns 71.62 ns -5.1%
JSON_Array_Of_Objects_Unique 468.24 ns 438.94 ns -6.3%
URITemplateRouter_Match 158.68 ns 148.39 ns -6.5%
URITemplateRouter_Match_BasePath 182.60 ns 170.06 ns -6.9%
JSON_Object_At_Last_Key_512 311.45 ns 286.83 ns -7.9%
JSON_Divisible_By_Decimal 387.00 ns 356.27 ns -7.9%
JSON_Object_Defines_Miss_Too_Small 3.42 ns 3.11 ns -9.1%
JSON_String_Fast_Hash_10 3.15 ns 2.86 ns -9.2%
JSON_String_Fast_Hash_100 3.15 ns 2.86 ns -9.3%
JSON_PropertySet_Filter_Object_Properties 40.84 ns 36.43 ns -10.8%
JSON_String_Key_Hash_10 2.72 ns 2.30 ns -15.7%
All 112 benchmarks
Benchmark main This branch Change
Crypto_CRC32_Large_JSONL 101.55 us 101.51 us -0.0%
Crypto_AES_GCM_Encrypt_128_1KB 1.25 us 1.24 us -1.1%
Crypto_AES_GCM_Decrypt_128_1KB 1.22 us 1.23 us +0.5%
Crypto_AES_GCM_Encrypt_256_1KB 1.29 us 1.28 us -0.4%
JOSE_VerifySignature_RS256 22.22 us 22.23 us +0.1%
JOSE_VerifySignature_ES512 575.07 us 575.71 us +0.1%
GZIP_Compress_ISO_Language_Set_3_Locations 29.87 ms 29.92 ms +0.2%
GZIP_Decompress_ISO_Language_Set_3_Locations 5.16 ms 5.15 ms -0.1%
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations 7.23 ms 7.21 ms -0.1%
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations 8.70 ms 8.70 ms +0.1%
GZIP_Compress_ISO_Language_Set_3_Schema 2.04 ms 2.05 ms +0.2%
GZIP_Decompress_ISO_Language_Set_3_Schema 427.13 us 425.30 us -0.4%
Markdown_To_HTML_Realistic_Document 5.16 ms 5.06 ms -1.9%
Markdown_To_HTML_Pathological 13.72 ms 13.20 ms -3.8%
Markdown_To_HTML_Short_Descriptions 726.66 ns 749.25 ns +3.1%
HTML_Build_Table_100000 38.22 ms 38.07 ms -0.4%
HTML_Render_Table_100000 1.76 ms 1.77 ms +0.5%
JSONLD_Catalog_Annotation_List_Populate 718.87 us 741.12 us +3.1%
JSONLD_Catalog_Materialize 3.59 ms 3.71 ms +3.3%
JSONL_Parse_Large 10.53 ms 10.44 ms -0.8%
JSONL_Parse_Large_GZIP 10.68 ms 10.64 ms -0.3%
URITemplateRouter_Create 21.76 us 22.00 us +1.1%
URITemplateRouter_Match 158.68 ns 148.39 ns -6.5%
URITemplateRouterView_Restore 8.33 us 8.29 us -0.5%
URITemplateRouterView_Match 129.04 ns 136.28 ns +5.6%
URITemplateRouterView_Arguments 473.80 ns 480.15 ns +1.3%
URITemplateRouter_Match_BasePath 182.60 ns 170.06 ns -6.9%
URITemplateRouterView_Match_BasePath 147.57 ns 156.51 ns +6.1%
JSONPath_Descendant_Filter_Nested 1.93 us 1.94 us +0.6%
OpenAPI_Frame_GSMTasks_3_0 153.10 ms 150.23 ms -1.9%
OpenAPI_Format_Synthetic_3_1 52.10 ms 51.18 ms -1.8%
Schema_Frame_WoT_References 2.27 ms 2.27 ms -0.2%
Schema_Frame_OMC_References 9.77 ms 9.80 ms +0.3%
Schema_Frame_OMC_Pointers 18.13 ms 18.23 ms +0.5%
Schema_Frame_OMC_Locations 8.44 ms 8.50 ms +0.7%
Schema_Frame_ISO_Language_Locations 40.94 ms 41.17 ms +0.6%
Schema_Frame_ISO_Language_Root 352.34 ns 355.61 ns +0.9%
Schema_Frame_KrakenD_References 15.35 ms 15.38 ms +0.2%
Schema_Frame_KrakenD_Reachable 142.48 ms 145.47 ms +2.1%
Schema_Frame_ISO_Language_Locations_To_JSON 31.25 ms 31.96 ms +2.3%
Schema_Frame_Many_Resources_References 115.32 ms 116.53 ms +1.1%
Schema_Frame_Deeply_Nested_References 10.82 ms 10.89 ms +0.6%
Schema_Format_ISO_Language 46.27 ms 46.39 ms +0.3%
Schema_Bundle_Meta_2020_12 685.01 us 682.60 us -0.4%
Schema_Bundle_Many_Remotes_With_Fragments 7.20 ms 7.29 ms +1.4%
Pointer_Object_Traverse 23.22 ns 23.24 ns +0.1%
Pointer_Object_Try_Traverse 28.03 ns 27.52 ns -1.8%
Pointer_Push_Back_Pointer_To_Weak_Pointer 130.49 ns 135.70 ns +4.0%
Pointer_Walker_Schema_ISO_Language 1.48 ms 1.49 ms +0.2%
Pointer_Untracked_Deeply_Nested 1.51 ms 1.51 ms +0.1%
Pointer_Tracked_Deeply_Nested 2.17 ms 2.19 ms +1.1%
Pointer_Position_Tracker_Get_Deeply_Nested 575.35 ns 589.32 ns +2.4%
Schema_Tracker_ISO_Language 4.92 ms 4.97 ms +0.8%
Schema_Tracker_ISO_Language_To_JSON 15.80 ms 16.30 ms +3.2%
JSON_Array_Of_Objects_Unique 468.24 ns 438.94 ns -6.3%
JSON_Array_Of_Integers_Unique_256 4.26 us 4.15 us -2.6%
JSON_Array_Of_Strings_Unique_Colliding_256 199.71 us 242.61 us +21.5%
JSON_Parse_1 5.79 us 5.68 us -1.9%
JSON_Parse_Real 5.61 us 5.47 us -2.5%
JSON_Parse_Real_Inexact 5.79 us 6.10 us +5.4%
JSON_Parse_Decimal 10.38 us 10.45 us +0.7%
JSON_Parse_Schema_ISO_Language 3.79 ms 3.77 ms -0.4%
JSON_Parse_Integer 4.31 us 4.37 us +1.3%
JSON_Parse_String_NonSSO_Plain 3.65 us 3.93 us +7.9%
JSON_Parse_String_SSO_Plain 3.05 us 3.07 us +0.6%
JSON_Parse_String_Escape_Heavy 17.21 us 17.82 us +3.6%
JSON_Parse_Object_Short_Keys 11.10 us 11.31 us +1.8%
JSON_Parse_Object_Scalar_Properties 5.65 us 5.75 us +1.8%
JSON_Parse_Object_Array_Properties 6.88 us 7.02 us +2.1%
JSON_Parse_Object_Object_Properties 6.84 us 7.09 us +3.7%
JSON_Parse_Nested_Containers 42.39 us 43.05 us +1.6%
JSON_Fast_Hash_Helm_Chart_Lock 75.45 ns 71.62 ns -5.1%
JSON_Equality_Helm_Chart_Lock 167.88 ns 168.09 ns +0.1%
JSON_String_Equal_10 5.68 ns 5.68 ns -0.0%
JSON_String_Equal_100 6.31 ns 6.31 ns -0.0%
JSON_String_Equal_Small_By_Perfect_Hash_10 0.62 ns 0.62 ns -0.1%
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 13.06 ns 13.70 ns +4.9%
JSON_String_Fast_Hash_10 3.15 ns 2.86 ns -9.2%
JSON_String_Fast_Hash_100 3.15 ns 2.86 ns -9.3%
JSON_String_Key_Hash_10 2.72 ns 2.30 ns -15.7%
JSON_String_Key_Hash_100 13.78 ns 13.38 ns -2.9%
JSON_Object_Defines_Miss_Same_Length 3.11 ns 3.11 ns +0.0%
JSON_Object_Defines_Miss_Too_Small 3.42 ns 3.11 ns -9.1%
JSON_Object_Defines_Miss_Too_Large 3.11 ns 3.11 ns +0.0%
JSON_From_String_Copy 9.16 ns 9.33 ns +1.9%
JSON_From_String_Temporary 8.31 ns 9.16 ns +10.2%
JSON_Number_To_Double 26.45 ns 25.43 ns -3.9%
JSON_Object_At_Last_Key_8 3.82 ns 3.74 ns -2.0%
JSON_Object_At_Last_Key_32 11.88 ns 11.83 ns -0.4%
JSON_Object_At_Last_Key_128 48.60 ns 48.67 ns +0.1%
JSON_Object_At_Last_Key_512 311.45 ns 286.83 ns -7.9%
JSON_Divisible_By_Decimal 387.00 ns 356.27 ns -7.9%
JSON_PropertySet_Contains 45.79 ns 44.17 ns -3.6%
JSON_PropertySet_Filter_Object_Properties 40.84 ns 36.43 ns -10.8%
JSON_PropertySet_Insert 461.82 ns 496.15 ns +7.4%
JSON_Stringify_Schema_Web_Of_Things 63.77 us 63.25 us -0.8%
JSON_Prettify_Schema_Web_Of_Things 178.66 us 172.84 us -3.3%
Regex_Lower_S_Or_Upper_S_Asterisk 2.10 ns 2.02 ns -3.7%
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.10 ns 2.10 ns +0.1%
Regex_Period_Asterisk 2.10 ns 2.10 ns +0.1%
Regex_Group_Period_Asterisk_Group 2.02 ns 2.10 ns +3.8%
Regex_Period_Plus 2.10 ns 2.02 ns -3.8%
Regex_Period 2.10 ns 2.10 ns -0.0%
Regex_Caret_Period_Plus_Dollar 2.10 ns 2.10 ns +0.1%
Regex_Caret_Group_Period_Plus_Group_Dollar 2.02 ns 2.10 ns +3.9%
Regex_Caret_Period_Asterisk_Dollar 2.10 ns 2.02 ns -3.7%
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.10 ns 2.10 ns +0.0%
Regex_Caret_X_Hyphen 7.08 ns 7.08 ns +0.0%
Regex_Period_Md_Dollar 30.73 ns 38.06 ns +23.9%
Regex_Caret_Slash_Period_Asterisk 8.01 ns 7.93 ns -1.1%
Regex_Caret_Period_Range_Dollar 3.34 ns 3.65 ns +9.3%
Regex_Nested_Backtrack 39.43 ns 43.43 ns +10.1%

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Benchmark windows/msvc

Measured against main at cd68e0c.

3 slower, 15 faster, 94 within 5%.

Benchmark main This branch Change
Schema_Frame_OMC_Pointers 40.92 ms 43.32 ms +5.8%
Pointer_Untracked_Deeply_Nested 2.51 ms 2.65 ms +5.4%
JSON_Object_At_Last_Key_32 22.93 ns 24.12 ns +5.2%
Regex_Caret_Period_Plus_Dollar 4.96 ns 4.71 ns -5.1%
Regex_Period 5.01 ns 4.71 ns -6.0%
Schema_Bundle_Meta_2020_12 1.57 ms 1.46 ms -7.1%
Regex_Caret_Group_Period_Asterisk_Group_Dollar 5.08 ns 4.71 ns -7.3%
JSON_Parse_Schema_ISO_Language 8.27 ms 7.60 ms -8.1%
JSON_Parse_Integer 7.18 us 6.60 us -8.2%
JSON_Parse_Real_Inexact 7.55 us 6.93 us -8.2%
JSON_Parse_Object_Scalar_Properties 7.59 us 6.96 us -8.3%
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 5.18 ns 4.71 ns -9.0%
Schema_Frame_Deeply_Nested_References 24.39 ms 22.12 ms -9.3%
Regex_Lower_S_Or_Upper_S_Asterisk 5.23 ns 4.71 ns -9.9%
Regex_Nested_Backtrack 64.47 ns 57.54 ns -10.7%
JSON_Parse_String_SSO_Plain 4.36 us 3.80 us -12.9%
Schema_Format_ISO_Language 111.40 ms 91.17 ms -18.2%
JSON_Parse_Decimal 14.60 us 11.89 us -18.5%
All 112 benchmarks
Benchmark main This branch Change
Regex_Lower_S_Or_Upper_S_Asterisk 5.23 ns 4.71 ns -9.9%
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 5.18 ns 4.71 ns -9.0%
Regex_Period_Asterisk 4.73 ns 4.70 ns -0.7%
Regex_Group_Period_Asterisk_Group 4.83 ns 4.71 ns -2.6%
Regex_Period_Plus 4.77 ns 4.71 ns -1.2%
Regex_Period 5.01 ns 4.71 ns -6.0%
Regex_Caret_Period_Plus_Dollar 4.96 ns 4.71 ns -5.1%
Regex_Caret_Group_Period_Plus_Group_Dollar 4.83 ns 4.71 ns -2.5%
Regex_Caret_Period_Asterisk_Dollar 4.75 ns 4.71 ns -0.9%
Regex_Caret_Group_Period_Asterisk_Group_Dollar 5.08 ns 4.71 ns -7.3%
Regex_Caret_X_Hyphen 8.07 ns 7.85 ns -2.7%
Regex_Period_Md_Dollar 46.63 ns 46.45 ns -0.4%
Regex_Caret_Slash_Period_Asterisk 7.56 ns 7.57 ns +0.1%
Regex_Caret_Period_Range_Dollar 5.48 ns 5.34 ns -2.5%
Regex_Nested_Backtrack 64.47 ns 57.54 ns -10.7%
JSON_Array_Of_Objects_Unique 556.07 ns 536.00 ns -3.6%
JSON_Array_Of_Integers_Unique_256 4.68 us 4.89 us +4.5%
JSON_Array_Of_Strings_Unique_Colliding_256 303.81 us 290.25 us -4.5%
JSON_Parse_1 8.90 us 8.66 us -2.6%
JSON_Parse_Real 7.67 us 7.64 us -0.4%
JSON_Parse_Real_Inexact 7.55 us 6.93 us -8.2%
JSON_Parse_Decimal 14.60 us 11.89 us -18.5%
JSON_Parse_Schema_ISO_Language 8.27 ms 7.60 ms -8.1%
JSON_Parse_Integer 7.18 us 6.60 us -8.2%
JSON_Parse_String_NonSSO_Plain 8.17 us 8.37 us +2.4%
JSON_Parse_String_SSO_Plain 4.36 us 3.80 us -12.9%
JSON_Parse_String_Escape_Heavy 21.87 us 21.30 us -2.6%
JSON_Parse_Object_Short_Keys 14.16 us 13.51 us -4.6%
JSON_Parse_Object_Scalar_Properties 7.59 us 6.96 us -8.3%
JSON_Parse_Object_Array_Properties 11.45 us 11.57 us +1.0%
JSON_Parse_Object_Object_Properties 11.62 us 11.80 us +1.6%
JSON_Parse_Nested_Containers 79.69 us 80.46 us +1.0%
JSON_Fast_Hash_Helm_Chart_Lock 106.13 ns 101.35 ns -4.5%
JSON_Equality_Helm_Chart_Lock 208.90 ns 208.62 ns -0.1%
JSON_String_Equal_10 10.18 ns 10.08 ns -1.0%
JSON_String_Equal_100 11.62 ns 11.60 ns -0.2%
JSON_String_Equal_Small_By_Perfect_Hash_10 2.20 ns 2.19 ns -0.2%
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 14.50 ns 14.50 ns -0.0%
JSON_String_Fast_Hash_10 6.37 ns 6.46 ns +1.3%
JSON_String_Fast_Hash_100 6.32 ns 6.33 ns +0.1%
JSON_String_Key_Hash_10 5.02 ns 5.05 ns +0.7%
JSON_String_Key_Hash_100 11.86 ns 11.94 ns +0.6%
JSON_Object_Defines_Miss_Same_Length 3.46 ns 3.50 ns +1.3%
JSON_Object_Defines_Miss_Too_Small 4.09 ns 4.11 ns +0.6%
JSON_Object_Defines_Miss_Too_Large 4.08 ns 4.07 ns -0.2%
JSON_From_String_Copy 63.72 ns 63.80 ns +0.1%
JSON_From_String_Temporary 57.77 ns 59.80 ns +3.5%
JSON_Number_To_Double 41.38 ns 40.89 ns -1.2%
JSON_Object_At_Last_Key_8 7.24 ns 7.27 ns +0.3%
JSON_Object_At_Last_Key_32 22.93 ns 24.12 ns +5.2%
JSON_Object_At_Last_Key_128 89.10 ns 89.29 ns +0.2%
JSON_Object_At_Last_Key_512 421.89 ns 427.38 ns +1.3%
JSON_Divisible_By_Decimal 382.39 ns 387.13 ns +1.2%
JSON_PropertySet_Contains 69.19 ns 69.28 ns +0.1%
JSON_PropertySet_Filter_Object_Properties 48.71 ns 48.24 ns -1.0%
JSON_PropertySet_Insert 1.31 us 1.30 us -0.7%
JSON_Stringify_Schema_Web_Of_Things 229.30 us 230.57 us +0.6%
JSON_Prettify_Schema_Web_Of_Things 719.22 us 721.10 us +0.3%
Pointer_Object_Traverse 70.01 ns 70.07 ns +0.1%
Pointer_Object_Try_Traverse 70.26 ns 70.10 ns -0.2%
Pointer_Push_Back_Pointer_To_Weak_Pointer 178.32 ns 184.11 ns +3.2%
Pointer_Walker_Schema_ISO_Language 10.96 ms 11.29 ms +3.0%
Pointer_Untracked_Deeply_Nested 2.51 ms 2.65 ms +5.4%
Pointer_Tracked_Deeply_Nested 3.77 ms 3.80 ms +0.7%
Pointer_Position_Tracker_Get_Deeply_Nested 564.25 ns 574.55 ns +1.8%
Schema_Tracker_ISO_Language 10.90 ms 11.31 ms +3.7%
Schema_Tracker_ISO_Language_To_JSON 63.94 ms 64.68 ms +1.2%
Schema_Frame_WoT_References 5.05 ms 5.03 ms -0.5%
Schema_Frame_OMC_References 21.90 ms 22.05 ms +0.7%
Schema_Frame_OMC_Pointers 40.92 ms 43.32 ms +5.8%
Schema_Frame_OMC_Locations 19.64 ms 20.25 ms +3.1%
Schema_Frame_ISO_Language_Locations 81.96 ms 85.68 ms +4.5%
Schema_Frame_ISO_Language_Root 2.34 us 2.30 us -1.5%
Schema_Frame_KrakenD_References 38.41 ms 40.24 ms +4.7%
Schema_Frame_KrakenD_Reachable 292.81 ms 305.90 ms +4.5%
Schema_Frame_ISO_Language_Locations_To_JSON 161.48 ms 168.22 ms +4.2%
Schema_Frame_Many_Resources_References 360.98 ms 362.59 ms +0.4%
Schema_Frame_Deeply_Nested_References 24.39 ms 22.12 ms -9.3%
Schema_Format_ISO_Language 111.40 ms 91.17 ms -18.2%
Schema_Bundle_Meta_2020_12 1.57 ms 1.46 ms -7.1%
Schema_Bundle_Many_Remotes_With_Fragments 30.20 ms 31.28 ms +3.6%
OpenAPI_Frame_GSMTasks_3_0 384.29 ms 386.10 ms +0.5%
OpenAPI_Format_Synthetic_3_1 131.06 ms 131.85 ms +0.6%
JSONPath_Descendant_Filter_Nested 2.84 us 2.85 us +0.4%
URITemplateRouter_Create 38.87 us 38.75 us -0.3%
URITemplateRouter_Match 231.86 ns 235.48 ns +1.6%
URITemplateRouterView_Restore 33.49 us 33.00 us -1.5%
URITemplateRouterView_Match 213.11 ns 217.87 ns +2.2%
URITemplateRouterView_Arguments 546.22 ns 538.56 ns -1.4%
URITemplateRouter_Match_BasePath 263.91 ns 267.32 ns +1.3%
URITemplateRouterView_Match_BasePath 242.62 ns 247.48 ns +2.0%
JSONL_Parse_Large 32.45 ms 32.54 ms +0.3%
JSONL_Parse_Large_GZIP 31.28 ms 31.56 ms +0.9%
JSONLD_Catalog_Annotation_List_Populate 2.96 ms 2.97 ms +0.1%
JSONLD_Catalog_Materialize 8.16 ms 8.21 ms +0.7%
HTML_Build_Table_100000 67.28 ms 67.19 ms -0.1%
HTML_Render_Table_100000 7.93 ms 7.85 ms -1.1%
Markdown_To_HTML_Realistic_Document 5.62 ms 5.67 ms +1.0%
Markdown_To_HTML_Pathological 17.42 ms 18.14 ms +4.2%
Markdown_To_HTML_Short_Descriptions 709.30 ns 698.90 ns -1.5%
GZIP_Compress_ISO_Language_Set_3_Locations 37.97 ms 37.84 ms -0.3%
GZIP_Decompress_ISO_Language_Set_3_Locations 9.71 ms 9.74 ms +0.3%
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations 12.19 ms 12.01 ms -1.5%
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations 15.25 ms 15.83 ms +3.8%
GZIP_Compress_ISO_Language_Set_3_Schema 2.34 ms 2.29 ms -2.3%
GZIP_Decompress_ISO_Language_Set_3_Schema 655.68 us 653.84 us -0.3%
JOSE_VerifySignature_RS256 21.44 us 21.37 us -0.3%
JOSE_VerifySignature_ES512 1.38 ms 1.37 ms -0.3%
Crypto_CRC32_Large_JSONL 103.42 us 103.12 us -0.3%
Crypto_AES_GCM_Encrypt_128_1KB 2.35 us 2.36 us +0.5%
Crypto_AES_GCM_Decrypt_128_1KB 2.36 us 2.38 us +0.8%
Crypto_AES_GCM_Encrypt_256_1KB 2.40 us 2.43 us +1.4%

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Benchmark macos/llvm

Measured against main at cd68e0c.

13 slower, 80 faster, 19 within 5%.

Benchmark main This branch Change
OpenAPI_Frame_GSMTasks_3_0 141.30 ms 196.52 ms +39.1%
URITemplateRouterView_Restore 10.49 us 13.29 us +26.8%
Schema_Bundle_Many_Remotes_With_Fragments 5.44 ms 6.27 ms +15.2%
HTML_Build_Table_100000 26.81 ms 30.55 ms +13.9%
Crypto_AES_GCM_Encrypt_256_1KB 4.22 us 4.73 us +12.2%
Schema_Frame_Deeply_Nested_References 12.61 ms 13.93 ms +10.4%
Schema_Frame_ISO_Language_Locations_To_JSON 22.35 ms 24.62 ms +10.1%
URITemplateRouter_Match_BasePath 202.00 ns 218.83 ns +8.3%
URITemplateRouter_Match 174.78 ns 188.22 ns +7.7%
JSONL_Parse_Large 6.45 ms 6.92 ms +7.4%
URITemplateRouterView_Arguments 555.08 ns 588.66 ns +6.0%
OpenAPI_Format_Synthetic_3_1 42.58 ms 44.90 ms +5.4%
URITemplateRouter_Create 18.21 us 19.18 us +5.3%
JSON_String_Equal_Small_By_Perfect_Hash_10 0.38 ns 0.36 ns -5.1%
JSON_Fast_Hash_Helm_Chart_Lock 70.08 ns 66.20 ns -5.5%
Schema_Frame_WoT_References 2.17 ms 2.03 ms -6.3%
Schema_Bundle_Meta_2020_12 465.25 us 434.48 us -6.6%
JSON_String_Fast_Hash_100 2.37 ns 2.20 ns -7.1%
JSON_Object_Defines_Miss_Too_Small 3.04 ns 2.82 ns -7.2%
JSON_Parse_String_NonSSO_Plain 3.53 us 3.25 us -7.7%
Markdown_To_HTML_Realistic_Document 3.29 ms 3.03 ms -8.0%
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 4.13 ns 3.79 ns -8.1%
Schema_Frame_KrakenD_Reachable 213.33 ms 195.84 ms -8.2%
JSON_Parse_Schema_ISO_Language 2.98 ms 2.72 ms -8.8%
JSON_Object_Defines_Miss_Same_Length 3.12 ns 2.84 ns -9.0%
JSON_Parse_Decimal 6.66 us 6.06 us -9.0%
Pointer_Tracked_Deeply_Nested 1.54 ms 1.40 ms -9.0%
Regex_Group_Period_Asterisk_Group 2.03 ns 1.82 ns -10.3%
Schema_Frame_ISO_Language_Locations 27.03 ms 24.17 ms -10.6%
JSON_From_String_Copy 12.57 ns 11.23 ns -10.7%
JSON_Object_At_Last_Key_512 240.50 ns 214.79 ns -10.7%
Schema_Frame_KrakenD_References 17.64 ms 15.74 ms -10.8%
JSON_Equality_Helm_Chart_Lock 199.64 ns 178.08 ns -10.8%
Markdown_To_HTML_Short_Descriptions 363.80 ns 323.01 ns -11.2%
Schema_Frame_OMC_Locations 9.75 ms 8.54 ms -12.3%
JSON_Object_Defines_Miss_Too_Large 3.26 ns 2.85 ns -12.7%
Schema_Tracker_ISO_Language 3.80 ms 3.30 ms -13.3%
JSON_String_Key_Hash_10 2.09 ns 1.80 ns -13.9%
JSON_String_Equal_100 7.66 ns 6.59 ns -14.0%
JSON_String_Equal_10 8.14 ns 6.99 ns -14.1%
JSON_Object_At_Last_Key_8 4.82 ns 4.11 ns -14.7%
JSON_PropertySet_Filter_Object_Properties 46.39 ns 39.19 ns -15.5%
JSON_Array_Of_Objects_Unique 479.03 ns 402.72 ns -15.9%
Regex_Caret_Slash_Period_Asterisk 6.11 ns 5.11 ns -16.3%
JSON_String_Fast_Hash_10 3.04 ns 2.51 ns -17.5%
Regex_Caret_Period_Asterisk_Dollar 2.19 ns 1.81 ns -17.5%
JSON_Parse_Integer 3.44 us 2.84 us -17.5%
JSON_PropertySet_Contains 57.50 ns 47.19 ns -17.9%
Regex_Nested_Backtrack 35.21 ns 28.87 ns -18.0%
Regex_Period_Asterisk 2.17 ns 1.78 ns -18.1%
JSON_PropertySet_Insert 394.30 ns 321.73 ns -18.4%
Pointer_Object_Traverse 25.19 ns 20.53 ns -18.5%
JSON_Prettify_Schema_Web_Of_Things 194.34 us 158.32 us -18.5%
JSON_Object_At_Last_Key_32 15.08 ns 12.28 ns -18.6%
GZIP_Decompress_ISO_Language_Set_3_Schema 383.69 us 311.95 us -18.7%
JSON_Number_To_Double 11.92 ns 9.68 ns -18.7%
Pointer_Push_Back_Pointer_To_Weak_Pointer 186.75 ns 151.23 ns -19.0%
JSON_Parse_Object_Array_Properties 4.27 us 3.45 us -19.2%
JSON_Array_Of_Strings_Unique_Colliding_256 197.23 us 159.03 us -19.4%
Regex_Caret_X_Hyphen 7.78 ns 6.27 ns -19.4%
JSON_Stringify_Schema_Web_Of_Things 79.09 us 63.75 us -19.4%
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.21 ns 1.77 ns -19.6%
JSON_Parse_Real_Inexact 4.09 us 3.28 us -19.9%
Schema_Frame_OMC_Pointers 23.65 ms 18.75 ms -20.7%
JSON_Parse_Real 4.25 us 3.35 us -21.2%
JSON_Array_Of_Integers_Unique_256 5.67 us 4.46 us -21.4%
JSON_Parse_Nested_Containers 31.75 us 24.92 us -21.5%
JSON_Divisible_By_Decimal 350.95 ns 274.53 ns -21.8%
JSON_Parse_Object_Scalar_Properties 3.69 us 2.89 us -21.8%
JSON_Object_At_Last_Key_128 73.02 ns 56.98 ns -22.0%
Pointer_Position_Tracker_Get_Deeply_Nested 489.43 ns 377.84 ns -22.8%
JSON_Parse_1 4.23 us 3.23 us -23.6%
JSON_Parse_Object_Object_Properties 4.59 us 3.51 us -23.6%
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.33 ns 1.77 ns -24.0%
Regex_Caret_Period_Range_Dollar 2.84 ns 2.14 ns -24.5%
Schema_Frame_OMC_References 13.36 ms 10.08 ms -24.5%
Crypto_CRC32_Large_JSONL 29.02 us 21.70 us -25.2%
Pointer_Walker_Schema_ISO_Language 2.00 ms 1.49 ms -25.4%
Regex_Lower_S_Or_Upper_S_Asterisk 2.40 ns 1.79 ns -25.5%
JSON_From_String_Temporary 8.81 ns 6.55 ns -25.6%
Regex_Period_Md_Dollar 25.94 ns 19.10 ns -26.4%
Regex_Caret_Group_Period_Plus_Group_Dollar 2.58 ns 1.89 ns -26.7%
GZIP_Compress_ISO_Language_Set_3_Schema 2.41 ms 1.76 ms -27.0%
JOSE_VerifySignature_ES512 1.46 ms 1.05 ms -28.1%
JSON_Parse_String_Escape_Heavy 23.80 us 17.02 us -28.5%
Crypto_AES_GCM_Encrypt_128_1KB 4.82 us 3.43 us -28.8%
Regex_Caret_Period_Plus_Dollar 2.58 ns 1.83 ns -29.2%
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations 7.74 ms 5.48 ms -29.2%
Pointer_Object_Try_Traverse 50.42 ns 35.48 ns -29.6%
Regex_Period_Plus 2.51 ns 1.75 ns -30.1%
JSON_Parse_Object_Short_Keys 8.16 us 5.57 us -31.7%
Regex_Period 2.57 ns 1.71 ns -33.2%
JSON_Parse_String_SSO_Plain 2.92 us 1.93 us -34.0%
All 112 benchmarks
Benchmark main This branch Change
Regex_Lower_S_Or_Upper_S_Asterisk 2.40 ns 1.79 ns -25.5%
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.33 ns 1.77 ns -24.0%
Regex_Period_Asterisk 2.17 ns 1.78 ns -18.1%
Regex_Group_Period_Asterisk_Group 2.03 ns 1.82 ns -10.3%
Regex_Period_Plus 2.51 ns 1.75 ns -30.1%
Regex_Period 2.57 ns 1.71 ns -33.2%
Regex_Caret_Period_Plus_Dollar 2.58 ns 1.83 ns -29.2%
Regex_Caret_Group_Period_Plus_Group_Dollar 2.58 ns 1.89 ns -26.7%
Regex_Caret_Period_Asterisk_Dollar 2.19 ns 1.81 ns -17.5%
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.21 ns 1.77 ns -19.6%
Regex_Caret_X_Hyphen 7.78 ns 6.27 ns -19.4%
Regex_Period_Md_Dollar 25.94 ns 19.10 ns -26.4%
Regex_Caret_Slash_Period_Asterisk 6.11 ns 5.11 ns -16.3%
Regex_Caret_Period_Range_Dollar 2.84 ns 2.14 ns -24.5%
Regex_Nested_Backtrack 35.21 ns 28.87 ns -18.0%
JSON_Array_Of_Objects_Unique 479.03 ns 402.72 ns -15.9%
JSON_Array_Of_Integers_Unique_256 5.67 us 4.46 us -21.4%
JSON_Array_Of_Strings_Unique_Colliding_256 197.23 us 159.03 us -19.4%
JSON_Parse_1 4.23 us 3.23 us -23.6%
JSON_Parse_Real 4.25 us 3.35 us -21.2%
JSON_Parse_Real_Inexact 4.09 us 3.28 us -19.9%
JSON_Parse_Decimal 6.66 us 6.06 us -9.0%
JSON_Parse_Schema_ISO_Language 2.98 ms 2.72 ms -8.8%
JSON_Parse_Integer 3.44 us 2.84 us -17.5%
JSON_Parse_String_NonSSO_Plain 3.53 us 3.25 us -7.7%
JSON_Parse_String_SSO_Plain 2.92 us 1.93 us -34.0%
JSON_Parse_String_Escape_Heavy 23.80 us 17.02 us -28.5%
JSON_Parse_Object_Short_Keys 8.16 us 5.57 us -31.7%
JSON_Parse_Object_Scalar_Properties 3.69 us 2.89 us -21.8%
JSON_Parse_Object_Array_Properties 4.27 us 3.45 us -19.2%
JSON_Parse_Object_Object_Properties 4.59 us 3.51 us -23.6%
JSON_Parse_Nested_Containers 31.75 us 24.92 us -21.5%
JSON_Fast_Hash_Helm_Chart_Lock 70.08 ns 66.20 ns -5.5%
JSON_Equality_Helm_Chart_Lock 199.64 ns 178.08 ns -10.8%
JSON_String_Equal_10 8.14 ns 6.99 ns -14.1%
JSON_String_Equal_100 7.66 ns 6.59 ns -14.0%
JSON_String_Equal_Small_By_Perfect_Hash_10 0.38 ns 0.36 ns -5.1%
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 4.13 ns 3.79 ns -8.1%
JSON_String_Fast_Hash_10 3.04 ns 2.51 ns -17.5%
JSON_String_Fast_Hash_100 2.37 ns 2.20 ns -7.1%
JSON_String_Key_Hash_10 2.09 ns 1.80 ns -13.9%
JSON_String_Key_Hash_100 2.44 ns 2.36 ns -3.3%
JSON_Object_Defines_Miss_Same_Length 3.12 ns 2.84 ns -9.0%
JSON_Object_Defines_Miss_Too_Small 3.04 ns 2.82 ns -7.2%
JSON_Object_Defines_Miss_Too_Large 3.26 ns 2.85 ns -12.7%
JSON_From_String_Copy 12.57 ns 11.23 ns -10.7%
JSON_From_String_Temporary 8.81 ns 6.55 ns -25.6%
JSON_Number_To_Double 11.92 ns 9.68 ns -18.7%
JSON_Object_At_Last_Key_8 4.82 ns 4.11 ns -14.7%
JSON_Object_At_Last_Key_32 15.08 ns 12.28 ns -18.6%
JSON_Object_At_Last_Key_128 73.02 ns 56.98 ns -22.0%
JSON_Object_At_Last_Key_512 240.50 ns 214.79 ns -10.7%
JSON_Divisible_By_Decimal 350.95 ns 274.53 ns -21.8%
JSON_PropertySet_Contains 57.50 ns 47.19 ns -17.9%
JSON_PropertySet_Filter_Object_Properties 46.39 ns 39.19 ns -15.5%
JSON_PropertySet_Insert 394.30 ns 321.73 ns -18.4%
JSON_Stringify_Schema_Web_Of_Things 79.09 us 63.75 us -19.4%
JSON_Prettify_Schema_Web_Of_Things 194.34 us 158.32 us -18.5%
Pointer_Object_Traverse 25.19 ns 20.53 ns -18.5%
Pointer_Object_Try_Traverse 50.42 ns 35.48 ns -29.6%
Pointer_Push_Back_Pointer_To_Weak_Pointer 186.75 ns 151.23 ns -19.0%
Pointer_Walker_Schema_ISO_Language 2.00 ms 1.49 ms -25.4%
Pointer_Untracked_Deeply_Nested 1.19 ms 1.14 ms -4.4%
Pointer_Tracked_Deeply_Nested 1.54 ms 1.40 ms -9.0%
Pointer_Position_Tracker_Get_Deeply_Nested 489.43 ns 377.84 ns -22.8%
Schema_Tracker_ISO_Language 3.80 ms 3.30 ms -13.3%
Schema_Tracker_ISO_Language_To_JSON 12.98 ms 13.43 ms +3.5%
Schema_Frame_WoT_References 2.17 ms 2.03 ms -6.3%
Schema_Frame_OMC_References 13.36 ms 10.08 ms -24.5%
Schema_Frame_OMC_Pointers 23.65 ms 18.75 ms -20.7%
Schema_Frame_OMC_Locations 9.75 ms 8.54 ms -12.3%
Schema_Frame_ISO_Language_Locations 27.03 ms 24.17 ms -10.6%
Schema_Frame_ISO_Language_Root 131.20 ns 134.60 ns +2.6%
Schema_Frame_KrakenD_References 17.64 ms 15.74 ms -10.8%
Schema_Frame_KrakenD_Reachable 213.33 ms 195.84 ms -8.2%
Schema_Frame_ISO_Language_Locations_To_JSON 22.35 ms 24.62 ms +10.1%
Schema_Frame_Many_Resources_References 87.22 ms 90.66 ms +3.9%
Schema_Frame_Deeply_Nested_References 12.61 ms 13.93 ms +10.4%
Schema_Format_ISO_Language 26.30 ms 25.58 ms -2.7%
Schema_Bundle_Meta_2020_12 465.25 us 434.48 us -6.6%
Schema_Bundle_Many_Remotes_With_Fragments 5.44 ms 6.27 ms +15.2%
OpenAPI_Frame_GSMTasks_3_0 141.30 ms 196.52 ms +39.1%
OpenAPI_Format_Synthetic_3_1 42.58 ms 44.90 ms +5.4%
JSONPath_Descendant_Filter_Nested 1.35 us 1.40 us +4.1%
URITemplateRouter_Create 18.21 us 19.18 us +5.3%
URITemplateRouter_Match 174.78 ns 188.22 ns +7.7%
URITemplateRouterView_Restore 10.49 us 13.29 us +26.8%
URITemplateRouterView_Match 129.31 ns 134.00 ns +3.6%
URITemplateRouterView_Arguments 555.08 ns 588.66 ns +6.0%
URITemplateRouter_Match_BasePath 202.00 ns 218.83 ns +8.3%
URITemplateRouterView_Match_BasePath 154.92 ns 152.28 ns -1.7%
JSONL_Parse_Large 6.45 ms 6.92 ms +7.4%
JSONL_Parse_Large_GZIP 6.88 ms 6.91 ms +0.5%
JSONLD_Catalog_Annotation_List_Populate 526.02 us 532.99 us +1.3%
JSONLD_Catalog_Materialize 2.53 ms 2.54 ms +0.2%
HTML_Build_Table_100000 26.81 ms 30.55 ms +13.9%
HTML_Render_Table_100000 1.90 ms 1.94 ms +2.5%
Markdown_To_HTML_Realistic_Document 3.29 ms 3.03 ms -8.0%
Markdown_To_HTML_Pathological 9.74 ms 9.89 ms +1.6%
Markdown_To_HTML_Short_Descriptions 363.80 ns 323.01 ns -11.2%
GZIP_Compress_ISO_Language_Set_3_Locations 29.60 ms 29.28 ms -1.1%
GZIP_Decompress_ISO_Language_Set_3_Locations 3.14 ms 3.13 ms -0.4%
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations 4.54 ms 4.64 ms +2.1%
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations 7.74 ms 5.48 ms -29.2%
GZIP_Compress_ISO_Language_Set_3_Schema 2.41 ms 1.76 ms -27.0%
GZIP_Decompress_ISO_Language_Set_3_Schema 383.69 us 311.95 us -18.7%
JOSE_VerifySignature_RS256 25.19 us 24.07 us -4.4%
JOSE_VerifySignature_ES512 1.46 ms 1.05 ms -28.1%
Crypto_CRC32_Large_JSONL 29.02 us 21.70 us -25.2%
Crypto_AES_GCM_Encrypt_128_1KB 4.82 us 3.43 us -28.8%
Crypto_AES_GCM_Decrypt_128_1KB 4.63 us 4.45 us -3.8%
Crypto_AES_GCM_Encrypt_256_1KB 4.22 us 4.73 us +12.2%

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 13 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="test/markdown/markdown_tables_test.cc">

<violation number="1" location="test/markdown/markdown_tables_test.cc:488">
P1: This expectation currently fails: `# Title` is accepted as a one-cell table row before block-start parsing can recognize the heading. End table continuation when the next line starts another block-level structure, or this test will keep the suite failing.</violation>
</file>

<file name="src/core/yaml/parser.h">

<violation number="1" location="src/core/yaml/parser.h:2219">
P2: This `break` leaves `next` as the alias, so the post-loop handoff queues it after `colon` and resumes parsing out of source order. Restore both tokens in source order before leaving the mapping.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

sourcemeta::core::markdown_to_html("| a |\n| --- |\n| 1 |\n# Title\n")};
EXPECT_EQ(result, "<table>\n<thead>\n<tr>\n<th>a</th>\n</tr>\n</thead>\n"
"<tbody>\n<tr>\n<td>1</td>\n</tr>\n</tbody>\n</table>\n"
"<h1>Title</h1>\n");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: This expectation currently fails: # Title is accepted as a one-cell table row before block-start parsing can recognize the heading. End table continuation when the next line starts another block-level structure, or this test will keep the suite failing.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At test/markdown/markdown_tables_test.cc, line 488:

<comment>This expectation currently fails: `# Title` is accepted as a one-cell table row before block-start parsing can recognize the heading. End table continuation when the next line starts another block-level structure, or this test will keep the suite failing.</comment>

<file context>
@@ -474,3 +477,13 @@ TEST(row_that_does_not_parse_closes_the_table) {
+      sourcemeta::core::markdown_to_html("| a |\n| --- |\n| 1 |\n# Title\n")};
+  EXPECT_EQ(result, "<table>\n<thead>\n<tr>\n<th>a</th>\n</tr>\n</thead>\n"
+                    "<tbody>\n<tr>\n<td>1</td>\n</tr>\n</tbody>\n</table>\n"
+                    "<h1>Title</h1>\n");
+}

</file context>

Comment thread src/core/yaml/parser.h
this->pending_tokens_.push_back(colon);
next = this->next_token();
continue;
break;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This break leaves next as the alias, so the post-loop handoff queues it after colon and resumes parsing out of source order. Restore both tokens in source order before leaving the mapping.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/core/yaml/parser.h, line 2219:

<comment>This `break` leaves `next` as the alias, so the post-loop handoff queues it after `colon` and resumes parsing out of source order. Restore both tokens in source order before leaving the mapping.</comment>

<file context>
@@ -2209,12 +2209,14 @@ private:
           this->pending_tokens_.push_back(colon);
-          next = this->next_token();
-          continue;
+          break;
         }
 
</file context>

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti

jviotti commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

@cubic-dev-ai review

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 11, 2026

Copy link
Copy Markdown

@cubic-dev-ai review

@jviotti I have started the AI code review. It will take a few minutes to complete.

@jviotti

jviotti commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

augment review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 94 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/core/jsonschema/jsonschema.cc">

<violation number="1" location="src/core/jsonschema/jsonschema.cc:49">
P2: `base_dialect_uri` now falls off a non-void function for an invalid `SchemaBaseDialect`, causing undefined behavior instead of returning an empty view. Retain the assertion and fallback return, or add an explicit failure path.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread src/core/openapi/bundle.cc Outdated
Comment thread src/core/jsonschema/vocabularies.cc
}

assert(false);
return {};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: base_dialect_uri now falls off a non-void function for an invalid SchemaBaseDialect, causing undefined behavior instead of returning an empty view. Retain the assertion and fallback return, or add an explicit failure path.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/core/jsonschema/jsonschema.cc, line 49:

<comment>`base_dialect_uri` now falls off a non-void function for an invalid `SchemaBaseDialect`, causing undefined behavior instead of returning an empty view. Retain the assertion and fallback return, or add an explicit failure path.</comment>

<file context>
@@ -44,9 +44,6 @@ auto sourcemeta::core::base_dialect_uri(const SchemaBaseDialect base_dialect)
-  return {};
 }
 
 auto sourcemeta::core::operator<<(std::ostream &stream,
@@ -487,9 +484,9 @@ auto core_vocabulary_known(
     case SchemaBaseDialect::JSON_SCHEMA_2019_09:
</file context>

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/core/uri/setters.cc
// to begin with a slash. Writing one over a relative path would hand that
// path's first segment to the host on the way back in
if (!this->host_.has_value() && this->path_.has_value() &&
!this->path_.value().starts_with('/')) {

@augmentcode augmentcode Bot Oct 11, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you consider the engaged-but-empty path_ case at src/core/uri/setters.cc:376: URI{"."}.resolve_from(URI{"custom:base"}) produces custom: with an empty stored path? Calling userinfo("user") on that URI now throws even though RFC 3986 permits an empty path with authority, while constructing URI{"custom:"} directly still accepts the same operation.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 21 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/core/http/include/sourcemeta/core/http_method.h">

<violation number="1" location="src/core/http/include/sourcemeta/core/http_method.h:67">
P2: These comments are indented two spaces farther than the function body, so `clang_format_test` fails. Align each comment with its `std::unreachable()` statement.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

return "PATCH";
}

// Clang settles that no other value arrives, so only GCC and MSVC

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: These comments are indented two spaces farther than the function body, so clang_format_test fails. Align each comment with its std::unreachable() statement.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/core/http/include/sourcemeta/core/http_method.h, line 67:

<comment>These comments are indented two spaces farther than the function body, so `clang_format_test` fails. Align each comment with its `std::unreachable()` statement.</comment>

<file context>
@@ -63,6 +63,12 @@ constexpr auto http_method_string(const HTTPMethod method) noexcept
       return "PATCH";
   }
+
+    // Clang settles that no other value arrives, so only GCC and MSVC
+    // need to be told that the end of this function is never reached
+#if !defined(__clang__)
</file context>

@jviotti
jviotti merged commit 112ba10 into main Oct 11, 2026
15 checks passed
@jviotti
jviotti deleted the cov-more branch October 11, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant