Skip to content

batch-changes: apply review follow-ups from #2019 - #2020

Merged
bahrmichael merged 1 commit into
mainfrom
batch-changes-rbac-review-followup
Sep 22, 2026
Merged

bahrmichael merged 1 commit into
mainfrom
batch-changes-rbac-review-followup

Conversation

@bahrmichael

@bahrmichael bahrmichael commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #2019, applying the review suggestions that landed after merge:

  • permissions-in-batch-changes.mdx: say batch_changes:write is needed to "create or execute" a batch change, not "create or administer", since "administer" reads like granting access.
  • admin/access-control/batch-changes.mdx: reflow the restrictToAdmins deprecation callout to one sentence per line.

🤖 Generated with Claude Code

- Use "execute" instead of "administer" for the batch_changes:write
  permission, so it does not read like granting access.
- Reflow the restrictToAdmins deprecation callout to one sentence per line.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sourcegraph-docs Ready Ready Preview Sep 22, 2026 2:16pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Direct preview links to pages changed in this PR:

@bahrmichael
bahrmichael merged commit 0633a27 into main Sep 22, 2026
7 checks passed
@bahrmichael
bahrmichael deleted the batch-changes-rbac-review-followup branch September 22, 2026 14:28

This branch was successfully deployed

1 active deployment
Preview 3eeb3aae Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants