Repository navigation
chore: upgrade katex to ^0.18.2, postcss-selector-parser to ^7.1.6 to address CVE-2026-103923, CVE-2026-104844 - #1717
Merged
Conversation
Neither has a patched release within the ranges requested upstream (mermaid pins katex ^0.16, tailwindcss 3 pins postcss-selector-parser ^6), so these use qualified resolutions overrides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe root Yarn resolutions now direct specified ChangesDependency resolutions
Priority: ⬆️ High Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The dependency upgrades resolve to patched versions, and no outstanding issue was identified. The PR is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
License Audit
Weak Copyleft Packages (informational)
Resolved Packages (9)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-2473
Fixes SOU-2474
Summary
Neither package has a patched release inside the ranges our dependencies request, and no top-level upgrade fixes it:
katexmermaid(^0.16.45)mermaid(12.1.0) still pins^0.16.47.postcss-selector-parsertailwindcss@3(^6.1.2),@tailwindcss/typography(^6.1.3),postcss-nested(^6.1.1)Following the CVE guidelines, this uses qualified
resolutionskeys for each existing source range. The existingpostcss-selector-parser@npm:6.0.10override now also targets^7.1.6, so a future@tailwindcss/typographybump can't bring the vulnerable range back.Risk
katex 0.16 → 0.18. The breaking changes are an internal
__defineFunctionAPI (0.17) and prefixed CSS class names (0.18). We don't use katex directly.mermaid.core.mjsloads it with a dynamicimport("katex")and only callsrenderToString(str, { throwOnError, displayMode, output }), which is unchanged. We don't load katex CSS separately.postcss-selector-parser 6 → 7. The only change in 7.0.0 is that insertions during iteration are now safe. It's used at build time, by Tailwind on our own CSS.
Testing
tailwindcss -i src/app/globals.css -c tailwind.config.ts) is byte-for-byte identical before and after.katex.renderToStringwith mermaid's options renders with bothmathmlandhtmlAndMathmloutput.Object.prototype.trust = true, 0.16.47 renders\href{...}as a live<a href>and 0.18.10 does not.vitest run src/ee/features/chat(mermaid diagram rendering): 49 files, 503 tests pass.🤖 Generated with Claude Code
Note
Low Risk
Scoped to Yarn resolutions and lockfile; PR testing reports identical Tailwind output and passing Mermaid/chat tests, with only transitive math/CSS build tooling affected.
Overview
Addresses CVE-2026-103923 and CVE-2026-104844 by forcing patched transitive versions through Yarn
resolutions, since upstream ranges (e.g. mermaid →katex, Tailwind v3 →postcss-selector-parser) do not include fixes in-tree.katexis overridden from the^0.16.45line (0.16.47) to ^0.18.2 (lock: 0.18.10), used indirectly for math in Mermaid diagrams.postcss-selector-parseris overridden from 6.x to ^7.1.6 for every existing resolution key (including the legacy6.0.10pin), so Tailwind-related build tooling cannot pull a vulnerable 6.x build.yarn.lockreflects the resolved versions (andcommander@^15as akatexdependency). CHANGELOG records the upgrade under Unreleased Fixed. No application source changes—dependency and lockfile maintenance only.Reviewed by Cursor Bugbot for commit f3d2020. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit