chore(examples): bump @solidjs/router to 2.0.0-next.39 by ryansolid · Pull Request #4040 · solidjs/solid

ryansolid · 2026-10-13T22:05:28Z

Requested by Ryan · project thread

Summary

Before: the examples pinned @solidjs/router 2.0.0-next.38. On a link, a hover and then the focus from the click's mousedown each preloaded it, so a click on a serverRouteComponent route in examples/hackernews sent the same GET three times (solidjs/solid-router#677).

After: chat, hackernews, hackernews-spa, notes and todos-server are on 2.0.0-next.39, which includes solidjs/solid-router#680. A link now preloads once per visit, so that click sends two requests instead of three, and focus followed by Enter sends one. The preload and the render still each make their own call. That last duplicate gets fixed in the router under #677.

examples/room stays on next.38 because a separate PR is deleting it.

How did you test this change?

pnpm install --lockfile-only, then pnpm install --frozen-lockfile
pnpm --filter @solidjs/compiler run build && pnpm run build: 28/28 tasks succeeded
pnpm typecheck and pnpm build in each of the five bumped examples: all clean

🤖 Generated with Claude Code

https://claude.ai/code/session_01V4hL2itq3ojS2Wy1acXctX

Generated by Claude Code

Picks up the intentPreload fix (solidjs/solid-router#680): a link now preloads once per visit, so a click on a server component route sends one preload instead of two. examples/room stays on next.38; it is being removed separately. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V4hL2itq3ojS2Wy1acXctX

changeset-bot · 2026-10-13T22:05:32Z

⚠️ No Changeset found

Latest commit: 105341b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

socket-security · 2026-10-13T22:05:56Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@solidjs/router@2.0.0-next.39

View full report

github-actions · 2026-10-13T22:08:38Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.47 KB	0 B	7.48 KB	✅
signals: + createStore	14.93 KB	0 B	14.94 KB	✅
signals: + isPending/latest	9.75 KB	0 B	9.77 KB	✅
app: render + one signal (the simple-app floor)	9.97 KB	0 B	9.98 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	17.89 KB	−43 B	17.93 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	29.51 KB	0 B	29.52 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.05 KB	0 B	13.07 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	14.62 KB	0 B	14.64 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.23 KB	0 B	29.24 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	10.15 KB	0 B	10.17 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	25.74 KB	0 B	25.75 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	31.62 KB	0 B	31.64 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.43 KB	0 B	11.43 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	34.08 KB	−1580 B	34.33 KB	✅	assets.js 0.78 KB, bind.js 1.83 KB, decode.js 6.23 KB, lazy-page.js 0.04 KB, regions.js 0.80 KB, trace.js 8.99 KB, wire.js 0.93 KB
page: live server components (base + live/GET + action + isPending/latest)	37.87 KB	−1648 B	38.15 KB	✅	assets.js 0.78 KB, bind.js 1.83 KB, decode.js 6.23 KB, lazy-page.js 0.04 KB, regions.js 0.80 KB, trace.js 8.99 KB, wire.js 0.93 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	34.92 KB	−2670 B	35.66 KB	✅	assets.js 0.78 KB, bind.js 1.83 KB, decode.js 6.23 KB, regions.js 0.80 KB, sc-comments.js 0.20 KB, trace.js 8.95 KB, wire.js 0.93 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	40.59 KB	−2663 B	41.21 KB	✅	eager (counted): web.js 21.54 KB; assets.js 0.78 KB, bind.js 1.84 KB, decode.js 6.23 KB, regions.js 0.79 KB, sc-comments.js 0.19 KB, trace.js 8.93 KB, wire.js 0.93 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.44 KB	−1585 B	41.79 KB	✅	assets.js 0.78 KB, bind.js 1.85 KB, decode.js 6.23 KB, lazy-page.js 0.04 KB, regions.js 0.80 KB, server.js 1.02 KB, serverForms.js 3.58 KB, trace.js 8.98 KB, wire.js 0.94 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	47.27 KB	−1578 B	47.49 KB	✅	eager (counted): client.js 27.75 KB; assets.js 0.78 KB, bind.js 1.84 KB, decode.js 6.23 KB, lazy-page.js 0.04 KB, regions.js 0.81 KB, server.js 1.02 KB, serverForms.js 3.30 KB, trace.js 8.96 KB, wire.js 0.94 KB
server: floor (getRequestEvent + isServer)	1.33 KB	0 B	1.34 KB	✅
server: renderToString (the server-render floor)	20.50 KB	0 B	20.51 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

…-6h93rx

coveralls · 2026-10-13T22:15:13Z

Coverage Report for CI Build 38475917720

Coverage remained the same at 77.515%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1326
Covered Lines:	1084
Line Coverage:	81.75%
Relevant Branches:	1040
Covered Branches:	750
Branch Coverage:	72.12%
Branches in Coverage %:	Yes
Coverage Strength:	27.53 hits per line

💛 - Coveralls

codspeed · 2026-10-13T22:24:51Z

Merging this PR will improve performance by 13.33%

⚠️

2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

readAllowed

propagation:diamond

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 194 untouched benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`createStore setter: delete + set one root key (#3044 overlay)`	2.1 ms	1.8 ms	+13.33%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/project-thread-6h93rx (105341b) with next (12e118e)}

ryansolid self-assigned this Oct 13, 2026

Merge remote-tracking branch 'origin/next' into claude/project-thread…

105341b

…-6h93rx

ryansolid merged commit 367befc into next Oct 13, 2026
8 checks passed

Navigation Menu

Repository navigation

chore(examples): bump @solidjs/router to 2.0.0-next.39 - #4040

chore(examples): bump @solidjs/router to 2.0.0-next.39#4040
ryansolid merged 2 commits into
nextfrom
claude/project-thread-6h93rx

ryansolid commented Oct 13, 2026

Uh oh!

changeset-bot Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

socket-security Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

coveralls commented Oct 13, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 13, 2026

Summary

How did you test this change?

Uh oh!

changeset-bot Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

socket-security Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026

Size (brotli, eager entry chunk)

Uh oh!

coveralls commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 38475917720

Coverage remained the same at 77.515%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 13.33%

Performance Changes

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot Bot commented Oct 13, 2026 •

edited

Loading

socket-security Bot commented Oct 13, 2026 •

edited

Loading

coveralls commented Oct 13, 2026 •

edited

Loading

codspeed Bot commented Oct 13, 2026 •

edited

Loading