Conversation
jeswr
approved these changes
Sep 21, 2026
jeswr
left a comment
jeswr
left a comment
Contributor
There was a problem hiding this comment.
Only the documentation comment is directly relevant to this PR. The rest can be applied separately in follow ups.
Contributor
There was a problem hiding this comment.
It looks like NodeJS support for the Web Lock API was added in Node 24. Node 22 is in maintenance until April 2027 - we should therefore document that Node v24 is the minimum supported node version.
I'd also double check they haven't backported it before writing the exact version.
Comment on lines
+182
to
+183
| const {promise: responseFromPopup, reject: cancelCodeRequest, resolve: respondWithCode} = Promise.withResolvers<string>() | ||
| signal.throwIfAborted() |
Contributor
There was a problem hiding this comment.
Why not throw before creating the promise.
| this.#dialog.addEventListener("close", onClose, onlyOnce) | ||
|
|
||
| return await promise | ||
| return await promise |
Contributor
There was a problem hiding this comment.
Suggested change
| return await promise | |
| return promise |
| this.#dialog.addEventListener("close", onClose, onlyOnce) | ||
|
|
||
| return await promise | ||
| return await promise |
Contributor
There was a problem hiding this comment.
Suggested change
| return await promise | |
| return promise |
| // One flow at a time, fellas | ||
| using _ = await this.#mutex.acquire() | ||
| return await navigator.locks.request("AuthorizationCodeFlow.getCode", async _ => { | ||
| this.#authorizationUri = authorizationUri |
Contributor
There was a problem hiding this comment.
Probably best to do this after the check of whether the signal is aborted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best reviewed ignoring whitespace.