Skip to content

refactor: remove unused UpdateNotification.SetHours method - #738

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-update-notification-set-hours
Oct 30, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-update-notification-set-hours

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes UpdateNotification.SetHours from internal/update/update.go for maintainers, because the Go deadcode tool reports it as unreachable. Less unused code to read and keep compiling.

  • Removes UpdateNotification.SetHours from internal/update/update.go
  • Removes its unit test from internal/update/update_test.go

Testing

  1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep SetHours and confirm there's no output
  2. Run go build ./... && go test ./... and confirm both pass

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Oct 30, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 30, 2026
@mwbrooks
mwbrooks requested a review from a team as a code owner October 30, 2026 16:19
@mwbrooks mwbrooks self-assigned this Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.17%. Comparing base (7a79c88) to head (fba4531).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   78.18%   78.17%   -0.02%     
==========================================
  Files         240      240              
  Lines       18166    18165       -1     
==========================================
- Hits        14203    14200       -3     
- Misses       3963     3965       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks - It ought be 24/7-ish?

@mwbrooks

Copy link
Copy Markdown
Member Author

Thanks @zimeg for the quick review! Around the clock it is 🙇

@mwbrooks
mwbrooks merged commit b5ccde4 into main Oct 30, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-remove-dead-update-notification-set-hours branch October 30, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants