Repository navigation
refactor: remove unused UpdateNotification.SetHours method - #738
Merged
mwbrooks merged 1 commit intoOct 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 78.18% 78.17% -0.02%
==========================================
Files 240 240
Lines 18166 18165 -1
==========================================
- Hits 14203 14200 -3
- Misses 3963 3965 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks @zimeg for the quick review! Around the clock it is 🙇 |
mwbrooks
deleted the
mwbrooks-remove-dead-update-notification-set-hours
branch
October 30, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal cleanup with no user-facing changes.
Summary
This pull request removes
UpdateNotification.SetHoursfrominternal/update/update.gofor maintainers, because the Godeadcodetool reports it as unreachable. Less unused code to read and keep compiling.UpdateNotification.SetHoursfrominternal/update/update.gointernal/update/update_test.goTesting
go run golang.org/x/tools/cmd/deadcode@latest ./... | grep SetHoursand confirm there's no outputgo build ./... && go test ./...and confirm both passRequirements