Skip to content

refactor: remove unused UpdateNotification.Env method - #734

Merged
mwbrooks merged 2 commits into
mainfrom
mwbrooks-remove-dead-update-notification-env
Oct 29, 2026
Merged

mwbrooks merged 2 commits into
mainfrom
mwbrooks-remove-dead-update-notification-env

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes UpdateNotification.Env from internal/update/update.go for maintainers, because the Go deadcode tool reports it as unreachable. Less unused code to read and keep compiling.

  • Removes UpdateNotification.Env from internal/update/update.go

Testing

  1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep 'UpdateNotification.Env$' and confirm there's no output
  2. Run go build ./... && go test ./... and confirm both pass

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Oct 29, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 29, 2026
@mwbrooks
mwbrooks requested a review from a team as a code owner October 29, 2026 16:28
@mwbrooks mwbrooks self-assigned this Oct 29, 2026
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.12%. Comparing base (90b4fb3) to head (bd8d7d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage   78.11%   78.12%           
=======================================
  Files         239      239           
  Lines       18121    18120    -1     
=======================================
  Hits        14156    14156           
+ Misses       3965     3964    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 @mwbrooks LGTM! Thanks for tidying this up.

@mwbrooks
mwbrooks merged commit e5e4f83 into main Oct 29, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-remove-dead-update-notification-env branch October 29, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants