Repository navigation
refactor: remove unused crop resize image from file function - #691
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 78.23% 78.21% -0.02%
==========================================
Files 239 239
Lines 18149 18144 -5
==========================================
- Hits 14199 14192 -7
- Misses 3950 3952 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks for the quick review @zimeg! 🙇🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal cleanup with no user-facing changes.
Summary
This pull request removes the unused
CropResizeImageRatioFromFilefunction found with the Godeadcodetool.CropResizeImageRatioFromFilefrominternal/image/image.gointernal/image/image_test.goCropResizeImageRatioFromFileToBytesis unchanged and still used for app iconsResizeImage*functionsPreview
N/A
Testing
go run golang.org/x/tools/cmd/deadcode@latest ./... | grep internal/imageand confirmCropResizeImageRatioFromFileis no longer listedgrep -rn "CropResizeImageRatioFromFile(" --include='*.go' .and confirm no references remainNotes
The
ResizeImage*functions still appear indeadcodeoutput on this branch until #690 merges.Requirements