Skip to content

refactor: remove unused crop resize image from file function - #691

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-crop-resize-image
Oct 9, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-crop-resize-image

Conversation

@mwbrooks

@mwbrooks mwbrooks commented Oct 9, 2026

Copy link
Copy Markdown
Member

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes the unused CropResizeImageRatioFromFile function found with the Go deadcode tool.

  • Removes CropResizeImageRatioFromFile from internal/image/image.go
  • Removes its unit tests from internal/image/image_test.go
  • CropResizeImageRatioFromFileToBytes is unchanged and still used for app icons
  • Follows refactor: remove unused resize image functions #690, which removes the unused ResizeImage* functions

Preview

N/A

Testing

  1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep internal/image and confirm CropResizeImageRatioFromFile is no longer listed
  2. Run grep -rn "CropResizeImageRatioFromFile(" --include='*.go' . and confirm no references remain

Notes

The ResizeImage* functions still appear in deadcode output on this branch until #690 merges.

Requirements

@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 9, 2026
@mwbrooks mwbrooks self-assigned this Oct 9, 2026
@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.21%. Comparing base (24242de) to head (8df1763).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   78.23%   78.21%   -0.02%     
==========================================
  Files         239      239              
  Lines       18149    18144       -5     
==========================================
- Hits        14199    14192       -7     
- Misses       3950     3952       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks added this to the Next Release milestone Oct 9, 2026
@mwbrooks
mwbrooks marked this pull request as ready for review October 9, 2026 19:55
@mwbrooks
mwbrooks requested a review from a team as a code owner October 9, 2026 19:55

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 @mwbrooks LGTM less code is better in this case so we can merge this whenever.

@mwbrooks

mwbrooks commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Thanks for the quick review @zimeg! 🙇🏻

@mwbrooks
mwbrooks merged commit 2e44890 into main Oct 9, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-remove-dead-crop-resize-image branch October 9, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants