Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 23acb21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the contribution! Before we can merge this, we need @sean0407 to sign the Salesforce Inc. Contributor License Agreement. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2766 by adding the optional top-level
bot_idfield toThreadBroadcastMessageEvent. Thread broadcasts can be authored by users or bots, androot.bot_iddescribes the parent message rather than the broadcast reply. This lets TypeScript consumers distinguish the reply author correctly.Validation
npm ci --ignore-scripts --no-audit --no-fund— completed in an isolated Node 20 Docker container.npm run build --workspace=@slack/types— passed.npm run test:types --workspace=@slack/types— passed, including a type fixture with top-levelbot_id.git diff --checkand the project patch policy — passed; 3 files changed, no binary files.Requirements