Repository navigation
Conversation
Gtk.DragIcon.get_for_drag is a named constructor in the current GTK vapi, so a plain call fails to compile and `new` would unref the drag icon the caller does not own. Bind gtk_drag_icon_get_for_drag as the unowned function it is. Assisted-by: DeepSeek:deepseek-flash AI-Scope: bound gtk_drag_icon_get_for_drag as an unowned static function in gdkextra.vapi and called it in drag_lift.vala.
Contributor
Author
|
@mirkobrombin for review when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gtk.DragIcon.get_for_dragis a named constructor in current gtk4.vapi, so thecall stops valac ("use
new' operator"), andnew` would unref an icon thecaller does not own. Bind the C function as unowned in gdkextra.vapi.
Verified: build fails on Debian forky without it, passes with it.
AI assistance: disclosed