Repository navigation
Conversation
dependency('cups') on the Vala library makes meson pass --pkg cups to valac,
which fails where valac ships no cups.vapi (Debian). Only the plain C
ipp_transport.c uses libcups, so build it as a static library with the cups
dependency and link it whole into libsingularity.
Assisted-by: Claude Code:claude-opus-5-5
AI-Scope: moved ipp_transport.c and the cups dependency into a link_whole static library in meson.build.
Contributor
Author
|
@mirkobrombin for review when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependency('cups')on the Vala library makes meson pass--pkg cupsto valac,which fails on Debian (no cups.vapi). Only the C file
ipp_transport.cuseslibcups, so it is now a static library with the cups dependency, linked whole.
Verified: upstream main fails to build on Debian forky with
"Package `cups' not found"; with this commit the library builds and all 47
tests pass.
AI assistance: disclosed