Skip to content

improvement(ui): use shared bordered workflow chips - #8121

Open
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/workflow-inline-chip-border
Open

BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/workflow-inline-chip-border

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing gray ChipTag treatment for workflow summary chips, removing the fixed inset-shadow border and local surface overrides.
  • Follow the shared hairline border thickness. Keep the 20px height, width cap, baseline alignment, truncation, and muted placeholders; fill and value text now use the gray variant palette.

Type of Change

  • Improvement

Testing

  • Workflow renderer: 144 tests passed; type check passed.
  • Workspace lint, block registry check, full audit suite, and docs parity passed.
  • Committed design check: zero new findings; existing static-analysis coverage gaps remain reported.
  • Compared real components with product CSS in light/dark browser fixtures, including filled, placeholder, and long values. Screenshot comparison is posted below.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing tests passing (no new behavior introduced)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 21, 2026 10:22pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the shared ChipTag styles preserve the removed local layout and state behavior.

Summary

This PR standardizes workflow summary chips on the shared gray ChipTag treatment.

  • Replaces the mono variant and local surface/inset-border styling with the gray variant.
  • Preserves the existing width cap, baseline adjustment, inline layout, height, truncation, and muted placeholder treatment.
  • No actionable correctness, security, or repository-rule issues were identified.

Reviews (1) · Last reviewed commit: "improvement(ui): use shared bordered wor..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before/after comparison using the actual InlineChip and ChipTag components with compiled product CSS (isolated fixture, not a full workflow session). Left: before; right: after. Both light and dark themes, filled values, muted placeholders, and a long value.

The chips remain 20px tall. At 2× display density, the new border is 0.5px instead of a fixed 1px inset shadow. The existing gray variant supplies the fill and text palette; unconstrained chips gain 1px in total width from their real border.

comparison

Enlarged crops of the same controls:

closeups

This branch was successfully deployed

1 active deployment
Preview 5616934a Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant