Skip to content

improvement(ui): share missing resource states - #8078

Open
BillLeoutsakosvl346 wants to merge 6 commits into
codex/typography-consolidationfrom
codex/control-fix-resource-empty-state
Open

improvement(ui): share missing resource states#8078
BillLeoutsakosvl346 wants to merge 6 commits into
codex/typography-consolidationfrom
codex/control-fix-resource-empty-state

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Add ResourceEmptyState for missing resources and replace seven product screens with the shared icon/title/description layout.
  • Retain the 32px icon, 20px heading and spacing. Center wrapped text and normalize neutral text contrast and remove the obsolete ResourceNotFound wrapper.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 8:20am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the refactor preserves the existing missing-resource conditions and content while centralizing only their presentation.

Summary

This PR consolidates seven missing-resource displays into a shared EMCN component while preserving their existing layout and copy.

  • Adds and exports ResourceEmptyState with canonical icon, heading, description, spacing, and centered wrapping.
  • Migrates workflow, file, folder, log, document, knowledge-base, and table missing states.
  • Removes the now-obsolete workspace-local ResourceNotFound component and export.
Diagram 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Missing[Missing resource detected] --> Shared[ResourceEmptyState]
  Shared --> Icon[Resource-specific icon]
  Shared --> Title[Resource-specific title]
  Shared --> Description[Resource-specific description]
  Shared --> Layout[Shared centered layout and tokens]
Loading

Reviews (3) · Last reviewed commit: "Merge branch 'codex/typography-consolida..."

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/emcn/src/components/resource-empty-state/resource-empty-state.tsx Outdated
@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Missing-resource screens reuse ResourceEmptyState. Heading/body contrast becomes canonical; icon size and layout remain similar.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 5ae9e4422a.

Before and after: light empty

Additional theme/state comparisons

Before and after: dark empty

Bill Leoutsakos added 4 commits September 22, 2026 00:39
Bill Leoutsakos Bill Leoutsakos
Merge branch 'codex/typography-consolidation' into codex/control-fix-…
1e115f6 
…resource-empty-state

# Conflicts:
#	apps/sim/app/workspace/[workspaceId]/components/resource/resource-not-found.tsx
#	apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/resource-content.tsx
#	apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx
Bill Leoutsakos Bill Leoutsakos
chore(ui): format resource heading utilities
fb3dbe6
Bill Leoutsakos Bill Leoutsakos
Merge branch 'codex/typography-consolidation' into codex/control-fix-…
315c577 
…resource-empty-state
Bill Leoutsakos Bill Leoutsakos
Merge branch 'codex/typography-consolidation' into codex/control-fix-…
8c3a1e9 
…resource-empty-state
@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from staging to codex/typography-consolidation September 22, 2026 08:18
@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 22, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — 8c3a1e9f Deployed Sep 22, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BillLeoutsakosvl346