improvement(ui): share public headings and product typography - #8069
BillLeoutsakosvl346 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Before / after visual comparisonPublic password/auth screens share PublicAuthHeader, preserving the existing heading and subcopy styles. Left = before; right = after. Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage. Current PR head checked at posting: |
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
bf036a1 to
a8070bc
Compare
4d8c337 to
f8bafb5
Compare
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
@greptile Please re-review the current head. The inline response explains the shared definition and the authorized design-system scope. |
There was a problem hiding this comment.
All reported issues were addressed across 60 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
|
@cubic-dev-ai review this PR. The description now covers the complete typography normalization and explicitly records its intended size changes; inline responses distinguish those from the unchanged public-heading extraction. |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |

Summary
Intentional visual differences
This final diff includes typography normalization as well as the public-heading extraction. It is not entirely pixel-identical: workflow and note headings (including the platform demonstration) use 16px instead of 17px; small file-extension/avatar labels use 10px instead of 9px; the upgrade heading uses 28px instead of 30px; and the mobile workspace greeting uses 24px instead of 26px, retaining 28px on desktop. These use existing nearby scale values instead of adding near-duplicate tokens.
Validation
All workspace type checks, lint, import/API audits, generators and the complete EMCN suite pass against the actual target. Existing typography-merging tests cover the shared utility names. The previously captured public-access heading fixtures match in light/dark; that exact-match statement applies to the heading extraction, not the intentionally normalized sizes above. Authenticated flows and every typography consumer were not rechecked in the browser during the stack refresh. Audit tooling and review artifacts are outside the PR.