improvement(ui): share additional-field disclosures

[BillLeoutsakosvl346]

Summary

• Add a controlled FieldDisclosure companion to FieldDivider, composing the existing Button and dashed divider lines.
• Replace the duplicated additional-fields rows in the workflow editor and table workflow sidebar. Preserve labels, spacing, chevron animation, handlers, permission guards, and caller-owned state. Keep the editor's read-only label unchanged.
• Expose the expanded state to assistive technology without introducing a new Button variant. Add the existing EMCN keyboard-focus ring to the disclosure; resting and mouse-click appearance stay unchanged.

Type of Change

• UI refactor

Testing

• All workspace type checks, lint, required audits, registry check, and docs generation/checks passed.
• EMCN: 351 tests passed. The focused disclosure test checks controlled state, click/focus behavior, disabled behavior, accessible state, and prevention of accidental form submission.
• Browser fixture using real components: matching dimensions, spacing, typography, colors, and chevron states in light/dark comparisons; keyboard Enter/Space toggles worked. Verified the focus ring appears for keyboard navigation in both themes and is absent after a mouse click. This is component fixture coverage, not a full live-workflow run.
• Source comparison confirms both consumers retain the same surrounding conditions, labels, callbacks, and state expressions.
• External conformance scan: no added or removed styling findings. These two duplicated rows were reuse candidates in the control inventory, not styling violations. Committed design check completed with zero usage violations and 21 intentional central-definition notifications for the existing row styling moved into EMCN and the reused keyboard-focus treatment. Known unchecked inputs remain outside the checker's coverage. Audit scripts and browser fixtures are outside this PR.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 21, 2026 3:31am UTC

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, accessibility, security, or repository-rule issues identified.

Summary

This PR introduces a reusable controlled FieldDisclosure component and replaces duplicated additional-fields disclosure rows in the workflow editor and table workflow sidebar.

• Preserves caller-owned expansion state, labels, permission guards, and toggle handlers.
• Exposes expansion state through aria-expanded and prevents accidental form submission.
• Adds a keyboard-only focus-visible ring using the established EMCN treatment.
• Adds DOM coverage for controlled state, activation, disabled behavior, accessibility attributes, and form behavior.

_{Reviews (2) · Last reviewed commit: "fix(ui): show keyboard focus on field di..."}

[cubic-dev-ai]

No issues found across 5 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[BillLeoutsakosvl346]

@greptile

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 5 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[BillLeoutsakosvl346]

Before / after visual comparison

Additional-field disclosure rows share the button/divider implementation. Expanded and collapsed treatments retain their spacing and appearance.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 2d56098b9b.