Repository navigation
Conversation
dav-sonn
approved these changes
Oct 28, 2026
dav-sonn
left a comment
dav-sonn
left a comment
Collaborator
There was a problem hiding this comment.
Good to go on my end. @ANBurdett - please confirm when I can merge it.
Contributor
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR packages validation do-files of the wealth module. Relevant unpackaged do-files are saved in Box:
CeMPA shared area_SimPaths_SimPathsUK\modules\wealth\05 validation
I nominate Ashely and David to review this PR, as suggested by GitHub.
The validation uses the Wealth and Asset Survey (WAS) for private pensions, hoursing and mortgage, and high-cost unsecured debts, while the pension shares and wealth additionally require UKHLS. The Living Cost and Food Survey (LCFS) is used for the consumption process.
Test shows all desirable output figures are smoothly produced. Specifically, the validation of pension shares and wealth requires a recent version of the "UKHLS_pooled_ipop.dta" file, which is compatible with the wealth module, to extact survey statistics. My test instead extracts UKHLS sruvey stats from "05 validation\Pension Wealth\pension validation.xlsx". Justin (@justin-ven), it would be greate if you can share the compatible "UKHLS_pooled_ipop.dta" file. I guess the Stata code that generates this compatible "UKHLS_pooled_ipop.dta" would need to be integrated to the existing "03_create_UKHLS_validation_targets.do" file. Please correct me if I am wrong here.