Repository navigation
Include the unit tests in the CodeQL scan [no-new-version] - #19
Merged
Merged
Conversation
autobuild runs gradle assemble, which does not compile the unit tests, so CodeQL scanned 13 of the 17 Java files. Build manually with the debug unit test sources too, without the build cache so that javac always runs under the CodeQL tracer, on JDK 21 like the Test job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178vjPYCurDqWnpvkLsVmZ1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeQL reports 13/17 Java files scanned (76 %).
autobuildruns./gradlew assemble, which compiles the library and the sample app but not the unit tests, soCacheHelperTest.javaandFlowLayoutManagerTest.javaare never seen by the tracer (the other two are the Javadoc-onlypackage-info.javafiles).The
java-kotlinjob now usesbuild-mode: manual:--no-build-cache:setup-gradleenables the build cache, and a compile task restoredFROM-CACHEwould skipjavac, hiding its files from CodeQLTestjob inci.yml, which builds the unit testsExpected result: 15/17 files; the two
package-info.javafiles hold no code.Testing
Analyze (java-kotlin)job of this PR.Generated by Claude Code