Repository navigation
[2/7] Check the edit before encoding and fail on placeholders - #225
Open
dazzatronus wants to merge 2 commits into
Open
dazzatronus wants to merge 2 commits into
dazzatronus wants to merge 2 commits into
Conversation
This was referenced Oct 19, 2026
dazzatronus
added this pull request to stack #231
October 19, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host can only fall back to a cloud render if the export tells it the browser can't draw the edit faithfully. The exporter encoded whatever was on the canvas: grey placeholders for failed loads, the pending animation for prompt-only AI clips, unkeyed chroma key. Before encoding, it now checks the edit and the browser and rejects with phase
unsupportedand a list ofissues(codes in the readme). During export, a clip still showing a placeholder, or a load still pending after 30 s, rejects with phaseassets. String font weights are read the wayRichTextPlayerreads them, soweight: "bold"doesn't raise a falsefontissue.About 550 lines, more than half tests: one per issue code.
exportBlobas the export enginespeedin frames and audioVerify:
npm run verify:ci; in a browser, a faithful edit exports in Safari and Firefox, andprompt-assets.jsonrejects withai-pendingand clip ids matchinggetEdit({ includeIds: true }).Risk:
export()refuses edits it used to encode best-effort; the changelog in [7/7] says so.