Repository navigation
Add localized listing videos example - #27
Merged
Merged
Conversation
Renders one property listing video in English, Spanish, German and Japanese from one saved template, with generated voice-overs, captions and merge-field text. Includes an optional translate.py that drafts missing translations with Gemini. Companion code for the video localization API guide.
render.py retried a lost connection for up to 15 minutes when it picked up a render from an earlier run. Now it stops with the network message after six failed attempts and keeps the log entry, so the next run picks the render up. Use python3 in docstrings, as the README does.
- Read Edit API errors ({message, response}) as well as gateway errors
({errors}), so a failed render or template save prints one line.
- Stop before any paid render if a language has an empty field.
- Stop on a submit timeout, because the render may have started.
- Render again when a finished video was deleted, instead of downloading
an expired URL.
- Name the language and Gemini's reason when a translation is blocked or
cut off.
- Stop polling on the overwritten Ingest status, and do not tell the user
to upload again after a timeout.
upload_footage.py now reads the error the same way as render.py and save_template.py. The empty-field message says what translate.py fills. The submit-timeout message no longer names a dashboard page.
- error_detail falls back to the raw body for any error shape it cannot read. - A finished video that was deleted downloads again from the old render, as before. A render again happens only when the URL has expired. - A submit timeout no longer stops the run. The other languages still render and download. - translate.py handles a non-JSON reply, and no longer says to run again after a blocked prompt. - The empty-field check also rejects fields with only spaces. - upload_footage.py names the source ID when a status check fails, and says how to get its status after a timeout.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
- Stop with one line when languages.json or renders.json is not valid JSON, or when an entry has no code. - Stop with one line when a finished render has no video URL. - Require requests 2.18, which made Response a context manager. - Write one instruction in each README sentence.
- A submit with no answer is reported apart from failed renders. The final line says a new run renders it again and uses credits again. - A null field counts as empty. translate.py uses the same empty test as render.py, so a field with only spaces gets translated. - A done render with no URL is rendered again on the next run. - error_detail falls back to the raw body when the message is empty. - languages.json must be a list with at least one language. - A Gemini reply with no usable translation says what to do next.
- languages.json may not use one code twice. - An unexpected reply for one language no longer stops the other languages. - An empty translation from Gemini is an error, not a saved translation. - error_detail falls back to the error title, then the HTTP reason. - The README says what happens after a request gets no answer.
Contributor
|
Please preserve the saved render ID when a download gets HTTP 429. Currently it’s deleted, so rerunning submits another paid render instead of retrying the download. Add a regression test covering that retry. |
A download that got HTTP 429 deleted the saved render ID, so the next run paid for a new render instead of downloading the finished one. A rate limit, a request timeout or a server error now keeps the render, and only another 4xx (an expired URL) starts a new render. The same rule is used when the render status is checked. test_render.py covers the retry: after a failed download the next run downloads the same render and does not submit again. CI runs the tests of each Python example that has a test file.
dazzatronus
approved these changes
Oct 15, 2026
dazzatronus
left a comment
dazzatronus
left a comment
Contributor
There was a problem hiding this comment.
The 429 retry issue is fixed: temporary download failures retain the render ID, and rerunning resumes the existing render without another submission. All five regression tests pass locally; the 429 test also fails against the previous revision, confirming it catches the original bug. Ruff and Python compilation pass, and current-head CI passes formatting, lint and the five tests. No remaining blocking findings from the review against the repository standards. Live production rendering was not rerun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renders one property listing video in English, Spanish, German and Japanese from one saved template. Each language gets its own AI voice-over, captions, headline and call to action. An optional translate.py drafts missing translations with Gemini.
Companion code for https://shotstack.io/learn/video-localization-api/
Checks done:
Choices a reviewer may question:
.mp4 stays. The "Not rendered" line names it.After merge: sync the article's code blocks to this revision and add the cookbook link to the article.