Repository navigation
Avoid Simulacron port collisions in PeersV2NodeRefreshIT - #1229
Conversation
The default resolver binds port 49152, which the CI runner can assign as an ephemeral client port. Keep multiple-nodes-per-IP behavior while starting Simulacron listeners at port 19042 instead.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe integration test setup now uses Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to This test-only port change has no confirmed merge-blocking failure; the integration-test run should confirm both Simulacron nodes start and the refresh assertions are reached. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the main change: preventing Simulacron port collisions in PeersV2NodeRefreshIT. |
| Description check | |
The description explains the port collision, the affected test, and the NodePerPortResolver fix. It directly matches the changeset. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scylla-4.x #1229 +/- ##
================================================
+ Coverage 81.76% 81.95% +0.19%
+ Complexity 9692 9648 -44
================================================
Files 980 975 -5
Lines 36687 36389 -298
Branches 5048 5010 -38
================================================
- Hits 29997 29824 -173
+ Misses 6690 6565 -125 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Issue
PeersV2NodeRefreshITlets Simulacron bind127.0.0.1:49152, a port the Ubuntu runner canalso assign to an outbound client socket. A collision fails setup with
BindNodeExceptionbefore the test exercises node refresh. This is the remaining flake described in #951 and
#1017; #1050 updated Simulacron but did not configure a resolver for this test.
Fix
Start the test's
NodePerPortResolverat port 19042 after enabling multiple nodes per IP. Thispreserves the
peers_v2metadata behavior while placing Simulacron's listener ports below therunner's ephemeral range. Simulacron 0.14.0.1 honors the explicit resolver.