Repository navigation
Remove DSE Graph runtime with deprecated compatibility stubs - #1036
Conversation
|
Important Review skippedToo many files! This PR contains 218 files, which is 118 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
📒 Files selected for processing (218)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aa660cf to
6c7b536
Compare
6c7b536 to
c9be75d
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
It removes a broad public API and integration surface across multiple modules, warranting final human verification despite comprehensive validation.
Pull request overview
Removes unsupported DSE Graph and TinkerPop integration while preserving generic reactive CQL, geometry, and schema metadata.
Changes:
- Deletes Graph APIs, processors, serializers, tests, fixtures, and configuration.
- Removes TinkerPop/JavaTuples dependencies and packaging hooks.
- Updates metrics, documentation, and supporting infrastructure.
File summaries
| File group | Description |
|---|---|
core/src/main/java/**/graph/** |
Removes Graph APIs, predicates, processors, results, reactive support, and serializers. |
core/src/test/java/**/graph/** |
Removes Graph unit tests and helpers. |
integration-tests/src/test/java/**/graph/** |
Removes Graph integration tests, assertions, traversal DSLs, and fixtures. |
osgi-tests/**/graph/** |
Removes Graph OSGi services, checks, and integration tests. |
test-infra/.../PatchedGremlinDslProcessor.java |
Removes the Gremlin annotation processor patch. |
test-infra/.../SessionRuleBuilder.java |
Removes Graph session options. |
test-infra/.../CqlSessionRuleBuilder.java |
Simplifies ordinary CQL session construction. |
pom.xml, core/pom.xml, core-shaded/pom.xml |
Removes managed and module-level TinkerPop dependencies. |
test-infra/pom.xml, integration-tests/pom.xml, osgi-tests/pom.xml |
Removes Graph test dependencies and annotation-processing configuration. |
distribution/pom.xml |
Removes TinkerPop and JavaTuples distribution dependencies. |
core/.../CqlSession.java |
Removes Graph session inheritance and updates documentation. |
core/.../BuiltInRequestProcessors*.java |
Removes Graph request processors and simplifies native-image substitutions. |
core/.../Dependency.java |
Removes TinkerPop runtime dependency detection. |
core/.../OptionsMap.java |
Removes Graph configuration defaults. |
core/.../MetricPaths.java, core/.../Dse*Metric.java |
Removes Graph metric definitions and parsing. |
core/.../Dropwizard*MetricUpdater.java |
Removes Dropwizard Graph metrics. |
metrics/micrometer/** |
Removes Micrometer Graph metrics and test cases. |
metrics/microprofile/** |
Removes MicroProfile Graph metrics. |
core/.../SpecificExecutionProfile.java |
Removes Graph options from Insights payloads. |
core/.../ExecutionProfilesInfoFinder.java |
Stops collecting Graph execution-profile options. |
core/.../insights/*Test.java |
Updates Insights expectations after Graph removal. |
core/.../ProxyAuthentication.java |
Removes Graph-statement proxy authentication overload. |
core/.../SerializationUtils.java |
Updates geometry serialization assertions after removing Graph-only distance support. |
osgi-tests/.../CcmStagedReactor.java |
Stops enabling DSE Graph workloads. |
osgi-tests/.../BundleOptions.java |
Removes TinkerPop OSGi bundles. |
osgi-tests/.../MailboxActivator.java |
Removes Graph mailbox service registration. |
osgi-tests/.../application.conf |
Removes Graph configuration. |
integration-tests/.../application.conf |
Removes Graph integration-test configuration. |
manual/core/integration/README.md |
Removes TinkerPop integration instructions. |
manual/core/graalvm/README.md |
Removes Graph native-image guidance. |
manual/developer/request_execution/README.md |
Removes Graph execution-model examples. |
upgrade_guide/README.md |
Removes obsolete Graph dependency guidance. |
upgrade_guide/from_3x/README.md |
Updates request-processing guidance. |
changelog/README.md |
Records the Graph removal. |
Review details
- Files reviewed: 141/203 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
c9be75d to
e7ad87e
Compare
915358f to
e3f1885
Compare
e3f1885 to
b193ee2
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The retained compatibility API conflicts with #1028’s acceptance criteria, and some API documentation still promises behavior that now always throws.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 167/214 changed files
- Comments generated: 2
- Review effort level: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Explicit default-valued Graph options in map-backed configuration are silently ignored without the promised deprecation warning.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 167/214 changed files
- Comments generated: 1
- Review effort level: Balanced
b193ee2 to
2b4c7c6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## scylla-4.x #1036 +/- ##
================================================
+ Coverage 81.96% 82.78% +0.81%
+ Complexity 9646 9185 -461
================================================
Files 975 917 -58
Lines 36389 34077 -2312
Branches 5010 4750 -260
================================================
- Hits 29828 28209 -1619
+ Misses 6561 5868 -693 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2b4c7c6 to
f868316
Compare
ef84beb to
8f04e55
Compare
Remove Graph execution, serialization, metrics, and runtime dependencies. Keep public signatures as deprecated shells with migration guidance.
Drop tests and OSGi services for unsupported Graph execution. Keep deprecated test-infra signatures for downstream compatibility.
Keep defaults and serialized OptionsMap values readable. Track explicit Graph settings internally so default-valued writes still warn.
Explain Graph migration, retained API shells, and dependency changes for the 4.19.2.2 release.
842bf8f to
f476908
Compare
Closes #1028. Part of #1025.
Removes unsupported DSE Graph runtime code: request processors, serializers, metric implementations, integration/OSGi fixtures, and the heavy runtime dependency chain. The Graph-only
Distancehelper and serialization proxy leave with their only callers; remaining DSE geometry and graph-schema metadata stay for #1025.Keeps public Graph API signatures, configuration options/defaults, and metric identifiers as deprecated compatibility shells. Graph construction and execution fail fast with migration guidance; legacy Graph configuration remains accepted and ignored with deprecation warnings; older serialized
OptionsMapvalues remain readable.Retains
gremlin-coreonly as an optional signature dependency and excludes TinkerPop/JavaTuples from the binary distribution. Upgrade guidance documents behavior before and after 4.19.2.2.Adds focused tests for deprecated API presence and fail-fast behavior, ignored Graph metrics, legacy configuration warnings/defaults, 4.19.2.1
OptionsMapdeserialization, config-loader isolation, and retained graph-schema refresh behavior.Decisions