Skip to content

Remove DSE Graph runtime with deprecated compatibility stubs - #1036

Merged
dkropachev merged 4 commits into
scylla-4.xfrom
cleanup/1028-remove-dse-graph
Oct 10, 2026
Merged

dkropachev merged 4 commits into
scylla-4.xfrom
cleanup/1028-remove-dse-graph

Conversation

@dkropachev

@dkropachev dkropachev commented Aug 31, 2026 •

Copy link
Copy Markdown

Closes #1028. Part of #1025.

Removes unsupported DSE Graph runtime code: request processors, serializers, metric implementations, integration/OSGi fixtures, and the heavy runtime dependency chain. The Graph-only Distance helper and serialization proxy leave with their only callers; remaining DSE geometry and graph-schema metadata stay for #1025.

Keeps public Graph API signatures, configuration options/defaults, and metric identifiers as deprecated compatibility shells. Graph construction and execution fail fast with migration guidance; legacy Graph configuration remains accepted and ignored with deprecation warnings; older serialized OptionsMap values remain readable.

Retains gremlin-core only as an optional signature dependency and excludes TinkerPop/JavaTuples from the binary distribution. Upgrade guidance documents behavior before and after 4.19.2.2.

Adds focused tests for deprecated API presence and fail-fast behavior, ignored Graph metrics, legacy configuration warnings/defaults, 4.19.2.1 OptionsMap deserialization, config-loader isolation, and retained graph-schema refresh behavior.

Decisions

@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 218 files, which is 118 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 0d62f197-671a-44b9-b3de-36f58b7cd6ff

📥 Commits

Reviewing files that changed from the base of the PR and between d27b35e and f476908.


📒 Files selected for processing (218)
  • changelog/README.md
  • core-shaded/pom.xml
  • core/pom.xml
  • core/src/main/java/com/datastax/dse/driver/api/core/auth/ProxyAuthentication.java
  • core/src/main/java/com/datastax/dse/driver/api/core/config/DseDriverOption.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/AsyncGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/BatchGraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/BatchGraphStatementBuilder.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/DseGraph.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/DseGraphRemoteConnectionBuilder.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/FluentGraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/FluentGraphStatementBuilder.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/GraphExecutionInfo.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/GraphNode.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/GraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/GraphSession.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/GraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/GraphStatementBuilderBase.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/PagingEnabledOptions.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/ScriptGraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/ScriptGraphStatementBuilder.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/predicates/CqlCollection.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/predicates/Geo.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/predicates/Search.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/reactive/ReactiveGraphNode.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/reactive/ReactiveGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/api/core/graph/reactive/ReactiveGraphSession.java
  • core/src/main/java/com/datastax/dse/driver/api/core/metrics/DseNodeMetric.java
  • core/src/main/java/com/datastax/dse/driver/api/core/metrics/DseSessionMetric.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/data/geometry/Distance.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/data/geometry/DistanceSerializationProxy.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/ByteBufUtil.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/BytecodeGraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/ContinuousAsyncGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/ContinuousGraphRequestHandler.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/CqlCollectionPredicate.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DefaultAsyncGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DefaultBatchGraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DefaultDseRemoteConnectionBuilder.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DefaultFluentGraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DefaultScriptGraphStatement.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DseGraphRemoteConnection.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DseGraphTraversal.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/DsePredicate.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/EditDistance.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GeoPredicate.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GeoUtils.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphConversions.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphExecutionInfoConverter.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphProtocol.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphRequestAsyncProcessor.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphRequestHandler.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphRequestSyncProcessor.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphResultIterator.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphResultSets.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphSON1SerdeTP.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphSON2SerdeTP.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphSONUtils.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphStatementBase.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphSupportChecker.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/GraphSupportRemoved.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/LegacyGraphNode.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/MultiPageGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/ObjectGraphNode.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/SearchPredicate.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/SearchUtils.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/SinglePageGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/AbstractDynamicGraphBinaryCustomSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/AbstractSimpleGraphBinaryCustomSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/ComplexTypeSerializerUtil.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/CqlDurationSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/DistanceSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/EditDistanceSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/GeometrySerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/GraphBinaryModule.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/GraphBinaryUtils.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/LineStringSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/PairSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/PointSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/PolygonSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/TupleValueSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/UdtValueSerializer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/buffer/DseNettyBuffer.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/binary/buffer/DseNettyBufferFactory.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/reactive/DefaultReactiveGraphNode.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/reactive/DefaultReactiveGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/reactive/FailedReactiveGraphResultSet.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/reactive/ReactiveGraphRequestProcessor.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/graph/reactive/ReactiveGraphResultSetSubscription.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/ExecutionProfilesInfoFinder.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/SpecificExecutionProfile.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/protocol/TinkerpopBufferPrimitiveCodec.java
  • core/src/main/java/com/datastax/oss/driver/api/core/CqlSession.java
  • core/src/main/java/com/datastax/oss/driver/api/core/config/OptionsMap.java
  • core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java
  • core/src/main/java/com/datastax/oss/driver/api/core/metrics/NodeMetric.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/DeprecatedGraphConfig.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/map/MapBasedDriverExecutionProfile.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/map/OptionsMapView.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/typesafe/TypesafeDriverConfig.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DefaultDriverContext.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/metrics/DropwizardNodeMetricUpdater.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/metrics/DropwizardSessionMetricUpdater.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/metrics/MetricPaths.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/session/BuiltInRequestProcessors.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/session/BuiltInRequestProcessorsSubstitutions.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/session/RequestProcessorRegistry.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/util/Dependency.java
  • core/src/main/resources/reference.conf
  • core/src/test/java/com/datastax/dse/driver/Assertions.java
  • core/src/test/java/com/datastax/dse/driver/DseTestDataProviders.java
  • core/src/test/java/com/datastax/dse/driver/TinkerpopBufferAssert.java
  • core/src/test/java/com/datastax/dse/driver/api/core/graph/GraphApiCompatibilityTest.java
  • core/src/test/java/com/datastax/dse/driver/api/core/graph/predicates/CqlCollectionTest.java
  • core/src/test/java/com/datastax/dse/driver/api/core/graph/predicates/GeoTest.java
  • core/src/test/java/com/datastax/dse/driver/api/core/graph/predicates/SearchTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/context/DseStartupOptionsBuilderTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/data/geometry/DistanceTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/data/geometry/SerializationUtils.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/ContinuousGraphRequestHandlerSpeculativeExecutionTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/ContinuousGraphRequestHandlerTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphExecutionInfoConverterTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphNodeTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphRequestHandlerTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphRequestHandlerTestHarness.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphResultSetTestBase.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphResultSetsTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphStatementBuilderBaseTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphSupportCheckerTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/GraphTestUtils.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/binary/GraphDataTypesTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/graph/reactive/ReactiveGraphRequestProcessorTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/ExecutionProfileMockUtil.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/ExecutionProfilesInfoFinderTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/InsightsClientTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/protocol/TinkerpopBufferPrimitiveCodecTest.java
  • core/src/test/java/com/datastax/oss/driver/api/core/config/OptionsMapTest.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/config/map/MapBasedDriverConfigTest.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/config/typesafe/TypesafeDriverConfigTest.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/context/DefaultDriverContextTest.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/context/MockedDriverContextFactory.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/metrics/MetricPathsTest.java
  • core/src/test/resources/config/options-map-4.19.2.1.base64
  • distribution/pom.xml
  • distribution/src/assembly/binary-tarball.xml
  • integration-tests/pom.xml
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/ClassicGraphDataTypeITBase.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/ClassicGraphGeoSearchIndexIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/ClassicGraphTextSearchIndexIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/CoreGraphDataTypeITBase.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/CoreGraphGeoSearchIndexIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/CoreGraphTextSearchIndexIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/CqlCollectionIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/GraphAuthenticationIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/GraphGeoSearchIndexITBase.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/GraphPagingIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/GraphSpeculativeExecutionIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/GraphTestSupport.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/GraphTextSearchIndexITBase.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/GraphTimeoutsIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/SampleGraphScripts.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/SocialTraversalDsl.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/SocialTraversalSourceDsl.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/TinkerEdgeAssert.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/TinkerElementAssert.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/TinkerGraphAssertions.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/TinkerPathAssert.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/TinkerVertexAssert.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/TinkerVertexPropertyAssert.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/reactive/DefaultReactiveGraphResultSetIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/remote/ClassicGraphDataTypeRemoteIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/remote/ClassicGraphTraversalRemoteIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/remote/CoreGraphDataTypeRemoteIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/remote/CoreGraphTraversalRemoteIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/remote/GraphTraversalMetaPropertiesRemoteIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/remote/GraphTraversalMultiPropertiesRemoteIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/remote/GraphTraversalRemoteITBase.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/ClassicGraphDataTypeFluentIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/ClassicGraphDataTypeScriptIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/ClassicGraphTraversalBatchIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/ClassicGraphTraversalIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/CoreGraphDataTypeFluentIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/CoreGraphDataTypeScriptIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/CoreGraphTraversalBatchIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/CoreGraphTraversalIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/GraphTraversalBatchITBase.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/GraphTraversalITBase.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/GraphTraversalMetaPropertiesIT.java
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/graph/statement/GraphTraversalMultiPropertiesIT.java
  • integration-tests/src/test/resources/application.conf
  • manual/core/graalvm/README.md
  • manual/core/integration/README.md
  • manual/developer/request_execution/README.md
  • metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerNodeMetricUpdater.java
  • metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerSessionMetricUpdater.java
  • metrics/micrometer/src/test/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerNodeMetricUpdaterTest.java
  • metrics/micrometer/src/test/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerSessionMetricUpdaterTest.java
  • metrics/microprofile/src/main/java/com/datastax/oss/driver/internal/metrics/microprofile/MicroProfileNodeMetricUpdater.java
  • metrics/microprofile/src/main/java/com/datastax/oss/driver/internal/metrics/microprofile/MicroProfileSessionMetricUpdater.java
  • osgi-tests/pom.xml
  • osgi-tests/src/main/java/com/datastax/oss/driver/api/osgi/service/graph/GraphMailboxService.java
  • osgi-tests/src/main/java/com/datastax/oss/driver/internal/osgi/MailboxActivator.java
  • osgi-tests/src/main/java/com/datastax/oss/driver/internal/osgi/service/graph/GraphMailboxServiceImpl.java
  • osgi-tests/src/main/resources/application.conf
  • osgi-tests/src/test/java/com/datastax/oss/driver/internal/osgi/OsgiDefaultIT.java
  • osgi-tests/src/test/java/com/datastax/oss/driver/internal/osgi/OsgiGraphIT.java
  • osgi-tests/src/test/java/com/datastax/oss/driver/internal/osgi/checks/GraphServiceChecks.java
  • osgi-tests/src/test/java/com/datastax/oss/driver/internal/osgi/support/BundleOptions.java
  • osgi-tests/src/test/java/com/datastax/oss/driver/internal/osgi/support/CcmStagedReactor.java
  • pom.xml
  • test-infra/pom.xml
  • test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/session/CqlSessionRuleBuilder.java
  • test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/session/SessionRule.java
  • test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/session/SessionRuleBuilder.java
  • test-infra/src/main/java/com/datastax/oss/driver/internal/gremlin/PatchedGremlinDslProcessor.java
  • test-infra/src/test/java/com/datastax/oss/driver/api/testinfra/session/CqlSessionRuleBuilderTest.java
  • upgrade_guide/README.md
  • upgrade_guide/from_3x/README.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch 3 times, most recently from aa660cf to 6c7b536 Compare September 1, 2026 23:35
@dkropachev
dkropachev requested review from nikagra and a balanced review from Copilot September 2, 2026 01:12
@dkropachev dkropachev self-assigned this Sep 2, 2026
@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch from 6c7b536 to c9be75d Compare September 2, 2026 01:12
@dkropachev dkropachev changed the title Remove unused DSE Graph support Remove DSE Graph support and TinkerPop integration Sep 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

It removes a broad public API and integration surface across multiple modules, warranting final human verification despite comprehensive validation.

Pull request overview

Removes unsupported DSE Graph and TinkerPop integration while preserving generic reactive CQL, geometry, and schema metadata.

Changes:

  • Deletes Graph APIs, processors, serializers, tests, fixtures, and configuration.
  • Removes TinkerPop/JavaTuples dependencies and packaging hooks.
  • Updates metrics, documentation, and supporting infrastructure.
File summaries
File group Description
core/src/main/java/**/graph/** Removes Graph APIs, predicates, processors, results, reactive support, and serializers.
core/src/test/java/**/graph/** Removes Graph unit tests and helpers.
integration-tests/src/test/java/**/graph/** Removes Graph integration tests, assertions, traversal DSLs, and fixtures.
osgi-tests/**/graph/** Removes Graph OSGi services, checks, and integration tests.
test-infra/.../PatchedGremlinDslProcessor.java Removes the Gremlin annotation processor patch.
test-infra/.../SessionRuleBuilder.java Removes Graph session options.
test-infra/.../CqlSessionRuleBuilder.java Simplifies ordinary CQL session construction.
pom.xml, core/pom.xml, core-shaded/pom.xml Removes managed and module-level TinkerPop dependencies.
test-infra/pom.xml, integration-tests/pom.xml, osgi-tests/pom.xml Removes Graph test dependencies and annotation-processing configuration.
distribution/pom.xml Removes TinkerPop and JavaTuples distribution dependencies.
core/.../CqlSession.java Removes Graph session inheritance and updates documentation.
core/.../BuiltInRequestProcessors*.java Removes Graph request processors and simplifies native-image substitutions.
core/.../Dependency.java Removes TinkerPop runtime dependency detection.
core/.../OptionsMap.java Removes Graph configuration defaults.
core/.../MetricPaths.java, core/.../Dse*Metric.java Removes Graph metric definitions and parsing.
core/.../Dropwizard*MetricUpdater.java Removes Dropwizard Graph metrics.
metrics/micrometer/** Removes Micrometer Graph metrics and test cases.
metrics/microprofile/** Removes MicroProfile Graph metrics.
core/.../SpecificExecutionProfile.java Removes Graph options from Insights payloads.
core/.../ExecutionProfilesInfoFinder.java Stops collecting Graph execution-profile options.
core/.../insights/*Test.java Updates Insights expectations after Graph removal.
core/.../ProxyAuthentication.java Removes Graph-statement proxy authentication overload.
core/.../SerializationUtils.java Updates geometry serialization assertions after removing Graph-only distance support.
osgi-tests/.../CcmStagedReactor.java Stops enabling DSE Graph workloads.
osgi-tests/.../BundleOptions.java Removes TinkerPop OSGi bundles.
osgi-tests/.../MailboxActivator.java Removes Graph mailbox service registration.
osgi-tests/.../application.conf Removes Graph configuration.
integration-tests/.../application.conf Removes Graph integration-test configuration.
manual/core/integration/README.md Removes TinkerPop integration instructions.
manual/core/graalvm/README.md Removes Graph native-image guidance.
manual/developer/request_execution/README.md Removes Graph execution-model examples.
upgrade_guide/README.md Removes obsolete Graph dependency guidance.
upgrade_guide/from_3x/README.md Updates request-processing guidance.
changelog/README.md Records the Graph removal.
Review details
  • Files reviewed: 141/203 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nikagra nikagra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline.

Comment thread upgrade_guide/README.md Outdated
Comment thread changelog/README.md Outdated
@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch from c9be75d to e7ad87e Compare September 4, 2026 11:29
@dkropachev dkropachev changed the title Remove DSE Graph support and TinkerPop integration Remove DSE Graph runtime with deprecated compatibility stubs Sep 4, 2026
@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch 2 times, most recently from 915358f to e3f1885 Compare September 4, 2026 16:48
@dkropachev
dkropachev requested a balanced review from Copilot September 9, 2026 00:21
@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch from e3f1885 to b193ee2 Compare September 9, 2026 00:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The retained compatibility API conflicts with #1028’s acceptance criteria, and some API documentation still promises behavior that now always throws.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 167/214 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Explicit default-valued Graph options in map-backed configuration are silently ignored without the promised deprecation warning.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 167/214 changed files
  • Comments generated: 1
  • Review effort level: Balanced

@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch from b193ee2 to 2b4c7c6 Compare October 9, 2026 20:03
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.92857% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.78%. Comparing base (d27b35e) to head (f476908).

Files with missing lines Patch % Lines
...er/internal/core/config/DeprecatedGraphConfig.java 67.60% 23 Missing ⚠️
...m/datastax/dse/driver/api/core/graph/DseGraph.java 47.36% 10 Missing ⚠️
...er/api/core/graph/ScriptGraphStatementBuilder.java 0.00% 10 Missing ⚠️
...ver/api/core/graph/BatchGraphStatementBuilder.java 0.00% 8 Missing ⚠️
...x/dse/driver/api/core/graph/predicates/Search.java 12.50% 7 Missing ⚠️
...session/BuiltInRequestProcessorsSubstitutions.java 0.00% 6 Missing ⚠️
...nal/core/config/typesafe/TypesafeDriverConfig.java 75.00% 5 Missing ⚠️
...er/internal/core/context/DefaultDriverContext.java 70.58% 5 Missing ⚠️
...river/api/core/graph/predicates/CqlCollection.java 0.00% 4 Missing ⚠️
...stax/dse/driver/api/core/graph/predicates/Geo.java 66.66% 4 Missing ⚠️
... and 12 more
Additional details and impacted files
@@               Coverage Diff                @@
##             scylla-4.x    #1036      +/-   ##
================================================
+ Coverage         81.96%   82.78%   +0.81%     
+ Complexity         9646     9185     -461     
================================================
  Files               975      917      -58     
  Lines             36389    34077    -2312     
  Branches           5010     4750     -260     
================================================
- Hits              29828    28209    -1619     
+ Misses             6561     5868     -693     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkropachev
dkropachev requested a review from nikagra October 9, 2026 20:41
Comment thread core/src/main/java/com/datastax/oss/driver/api/core/config/OptionsMap.java Outdated
@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch from 2b4c7c6 to f868316 Compare October 9, 2026 23:31
@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch from ef84beb to 8f04e55 Compare October 10, 2026 00:45
Remove Graph execution, serialization, metrics, and runtime dependencies.
Keep public signatures as deprecated shells with migration guidance.
Drop tests and OSGi services for unsupported Graph execution. Keep
deprecated test-infra signatures for downstream compatibility.
Keep defaults and serialized OptionsMap values readable. Track explicit
Graph settings internally so default-valued writes still warn.
Explain Graph migration, retained API shells, and dependency changes
for the 4.19.2.2 release.
@dkropachev
dkropachev force-pushed the cleanup/1028-remove-dse-graph branch from 842bf8f to f476908 Compare October 10, 2026 02:01
@dkropachev
dkropachev requested a review from nikagra October 10, 2026 02:24
@dkropachev
dkropachev merged commit 1aae863 into scylla-4.x Oct 10, 2026
34 checks passed
@dkropachev
dkropachev deleted the cleanup/1028-remove-dse-graph branch October 10, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DSE Graph support and TinkerPop integration

3 participants