-
Notifications
You must be signed in to change notification settings - Fork 392
Breaking: 以 OPFS 储存 Code #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cyfung1031
wants to merge
10
commits into
release/v1.4
Choose a base branch
from
breaking/ScriptCodeDAONew
base: release/v1.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Breaking: 以 OPFS 储存 Code #1316
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0833ed8
Breaking: 以 OPFS 储存 Code
cyfung1031 4fff717
过渡期间
cyfung1031 a61d5b5
migrations 修正
cyfung1031 87ba347
Merge remote-tracking branch 'origin/release/v1.4' into breaking/Scri…
CodFrm bc9a6e1
✅ 为 ScriptCodeDAO OPFS 迁移编写测试和 OPFS mock
CodFrm 69f64e8
♻️ ScriptCodeDAO 内部改为 OPFS 优先 + chrome.storage.local fallback
CodFrm 4768e7a
🐛 修正迁移逻辑:saveToOPFS 避免写放大 + 恢复数组格式 + await + 顺序保证
CodFrm bed286b
♻️ 所有调用方恢复使用 ScriptCodeDAO(内部已支持 OPFS)
CodFrm 2fa931b
♻️ ScriptCodeDAO 去掉 extends Repo + save 容错 + OPFS mock 抽离
CodFrm bb36715
Merge branch 'release/v1.4' into breaking/ScriptCodeDAONew
cyfung1031 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
♻️ 所有调用方恢复使用 ScriptCodeDAO(内部已支持 OPFS)
- Loading branch information
commit bed286b48cb6cb7981f95e97dab0a4d07b1a7773
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepareScriptByCode 这里仍用
if (!scriptCode)判断旧脚本 code 是否存在,但 ScriptCodeDAONew.get() 当前不会返回 undefined(缺文件时返回空字符串对象),会导致缺失 code 的情况不再抛 error_old_script_code_missing,而是继续用空 code 走后续逻辑。建议配合调整 ScriptCodeDAONew.get() 的返回语义,或在这里改为检查 code.code 是否为空。