Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice this when implementing
snt://links used here:When a link is opened by an installation that lacks the component implementing it (e.g., a Fiji install that is not subscribed
to an update site), LinkService#handle(URI) only logged a debug message, so the link appeared to do nothing.
This is easy to hit because fiji:// may receive a
fiji://<component>/...link, regardless of which components it has.In the case of SNT, a
fiji://snt/...link requires the Neuroanatomy update site.This add
LinkService#handleUnsupported(URI), called when no handler matches.The default implementation keeps the previous debug logging
DefaultLinkServiceoverrides it to log a warning and, if a UIService is available and the JVM is not headless, show an error dialog with the (truncated) link and a generic hint to install or update the missing component. When scijava.app.directory is set, the dialog also reports which installation received the link, to help diagnose setups with several side-by-side installations (which is related to #3)