test(vscode): drop the wall-clock retry assertion from the registry harness - #63
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…arness The continuous-interruption test asserted `attempts > 1` inside a 50ms budget with 5ms retry delays. The suite runs inside the extension host during activation, so one stalled retry delay can outlast the budget and leave a correct loop at attempts=1 (Windows E2E, run 35502494622). Retrying is already proven by the interrupted-window test; this test's own point is that continuous interruption ends in a timeout.
fi3ework
force-pushed
the
fix/harness-virtual-clock
branch
from
September 20, 2026 10:52
e6990cb to
eb30fce
Compare
fi3ework
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb30fce2b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…window test The interrupted-window test now uses a 5ms retry delay, so the positive delay branch stays covered by an exact attempt count under a 1000ms budget that a stalled runner cannot exhaust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows E2E flake seen on
main(run 35502494622):VS Code test harness fail-closed guards › continuous interruption times out instead of passing partiallyfailed withattempts=1.Root cause. The test feeds an always-failing probe with
timeoutMs: 50, retryDelayMs: 5and assertedattempts > 1. The suite runs inside the live extension host as the first suite of the lint slice, while activation (rslint worker spawn, file watchers) is still in progress, so a single stalled 5ms retry delay can outlast the 50ms budget. The loop then correctly gives up at the deadline after one attempt, and the assertion cannot tell that apart from "never retried".Fix. Drop the
attempts > 1assertion. Retrying is already proven by the sibling test (an interrupted window resets consecutive readiness, which assertsattempts: 4); this test's own point is that continuous interruption ends in aTimed outrejection, which stays asserted. A comment records the deviation from upstream.No production code changes.