Repository navigation
[openui5] install ui5/distribution - #23709
Merged
Merged
Conversation
Member
|
thanks. |
linev
approved these changes
Oct 14, 2026
Test Results 23 files 23 suites 3d 20h 31m 50s ⏱️ For more details on these failures, see this check. Results for commit 1dc95eb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Since #23179, openui5 is downloaded with
ExternalProject_Addinto${CMAKE_BINARY_DIR}/ui5/distribution, and the install rule for that directory was removed, although the PR description says it "is installed inui5/distribution/directory".The only remaining rule is
install(DIRECTORY ui5/ ...)in the top-levelCMakeLists.txt. Since it uses a relative path, CMake resolves it against the source directory, so it only installs ROOT's own ui5 sources (browser,canv,eve7, ...). For an out-of-source build with-Dbuiltin_openui5=ON,<prefix>/ui5/distributionis therefore missing after installation and the browser falls back tohttps://openui5.hana.ondemand.com/1.152.0/. Webgui then does not work without network access, even thoughbuiltin_openui5=ONis now required withwebgui=ON(#23691).This PR restores the install rule for
ui5/distribution.Checklist:
Tested on AlmaLinux 9 with an out-of-source build of master and
-Dbuiltin_openui5=ON: without this changecmake --installproduces noui5/distribution, with itui5/distribution/resources/sap-ui-core.jsis installed.