Skip to content

[openui5] install ui5/distribution - #23709

Merged
linev merged 1 commit into
root-project:masterfrom
jmcarcell:install-openui5
Oct 14, 2026
Merged

linev merged 1 commit into
root-project:masterfrom
jmcarcell:install-openui5

Conversation

@jmcarcell

Copy link
Copy Markdown
Contributor

This Pull request:

Changes or fixes:

Since #23179, openui5 is downloaded with ExternalProject_Add into ${CMAKE_BINARY_DIR}/ui5/distribution, and the install rule for that directory was removed, although the PR description says it "is installed in ui5/distribution/ directory".

The only remaining rule is install(DIRECTORY ui5/ ...) in the top-level CMakeLists.txt. Since it uses a relative path, CMake resolves it against the source directory, so it only installs ROOT's own ui5 sources (browser, canv, eve7, ...). For an out-of-source build with -Dbuiltin_openui5=ON, <prefix>/ui5/distribution is therefore missing after installation and the browser falls back to https://openui5.hana.ondemand.com/1.152.0/. Webgui then does not work without network access, even though builtin_openui5=ON is now required with webgui=ON (#23691).

This PR restores the install rule for ui5/distribution.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Tested on AlmaLinux 9 with an out-of-source build of master and -Dbuiltin_openui5=ON: without this change cmake --install produces no ui5/distribution, with it ui5/distribution/resources/sap-ui-core.js is installed.

@jmcarcell
jmcarcell requested a review from bellenot as a code owner October 14, 2026 07:23
@dpiparo dpiparo added the in:ML Everything under ROOT/ML label Oct 14, 2026
@dpiparo
dpiparo requested a review from linev October 14, 2026 07:31
@dpiparo dpiparo removed the in:ML Everything under ROOT/ML label Oct 14, 2026
@dpiparo

dpiparo commented Oct 14, 2026

Copy link
Copy Markdown
Member

thanks.

@github-actions

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 20h 31m 50s ⏱️
 3 888 tests  3 885 ✅ 0 💤 3 ❌
79 711 runs  79 706 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 1dc95eb.

@linev
linev merged commit 9991e72 into root-project:master Oct 14, 2026
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants