Repository navigation
[core] Add essential unit tests for TDatime - #23641
ravindra-RKB wants to merge 1 commit into
Conversation
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
Thank you very much for adding this missing fundamental unit tests.
The PR title use the word comprehensive which seems to be implying that a much larger set of tests covering the entirety of the TDatime API is planned to be added to this PR or did we mean a more limited scope (eg. Add essential unit test ... or fundamental or startup or something else)?
57a7414 to
d6bfe10
Compare
|
@pcanal Thanks for the feedback! You're completely right 'essential' is much more accurate for this scope. I have updated the PR title and commit message accordingly. Let me know if anything else is needed, otherwise this is ready for your review and to have the CI workflows triggered! |
pcanal
changed the title
Test Results 24 files 24 suites 4d 2h 55m 44s ⏱️ For more details on these failures, see this check. Results for commit 6a9e431. ♻️ This comment has been updated with latest results. |
d6bfe10 to
6a9e431
Compare
|
@pcanal Hi, it looks like the CI failures are false positives. The Could you please re-trigger the failed jobs or merge it manually? Thanks! |
This PR introduces missing essential unit tests for the TDatime class to ensure date and time operations, constructors, operators, and getter functions are tested against the ROOT test framework. This adds fundamental test coverage and ensures long-term stability for this module.
6a9e431 to
2ca0ae1
Compare
This branch has not been deployed
2 participants
This Pull request:
Changes or fixes:
This PR introduces missing unit tests for the
TDatimeclass to ensure all date and time operations, constructors, operators, and getter functions are thoroughly tested against the ROOT test framework. This adds significant test coverage and ensures long-term stability for this foundational module.Checklist: