Repository navigation
[roottest] Don't create a TApplication in ForeignCArray test - #23634
Merged
guitargeek merged 1 commit intoOct 7, 2026
Merged
guitargeek merged 1 commit into
guitargeek merged 1 commit into
Conversation
The TestForeignCArray executable created a TApplication without "-b". When $DISPLAY is set, ROOT then starts in graphics mode and tries to open the X display. If the X server rejects the connection, Xlib prints "Authorization required, but no authorization protocol specified" to stderr, which ends up in the compared output and fails the test. The test only exercises I/O of a CArray<ForeignData>, so it doesn't need a TApplication at all. Fixes this test failure on my system: ```txt 4/4 Test root-project#1924: roottest-root-io-ForeignCArray-mytest ....................***Failed 0.35 sec -- TEST COMMAND -- cd /home/rembserj/code/root/root_build/roottest/root/io/ForeignCArray /nix/store/xjl7p8dvyk2j53kqf7f43kdj4ypbxz7g-coreutils-9.11/bin/timeout -s USR2 270s ./TestForeignCArray -- BEGIN TEST OUTPUT -- Authorization required, but no authorization protocol specified CArray[3] ForeignData 0 ForeignData 0 ForeignData 0 ~ForeignData 3 ~ForeignData 2 ~ForeignData 1 Array CArray[0] ForeignData 0 ForeignData 0 ForeignData 0 1 2 3 -- END TEST OUTPUT -- -- BEGIN OUTDIFF OUTPUT -- --- /home/rembserj/code/root/root_src/roottest/root/io/ForeignCArray/mytest.ref Mon Oct 5 22:38:48 2026 +++ /home/rembserj/code/root/root_build/roottest/root/io/ForeignCArray/mytest.log Wed Oct 7 09:49:21 2026 @@ -1,3 +1,4 @@ +Authorization required, but no authorization protocol specified CArray[3] ForeignData 0 ForeignData 0 -- END OUTDIFF OUTPUT -- CMake Error at /home/rembserj/code/root/root_src/cmake/modules/RootTestDriver.cmake:283 (message): compare 'stdout' error: 1 ```
Test Results 23 files 23 suites 3d 18h 16m 49s ⏱️ For more details on these failures, see this check. Results for commit 8903c3a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TestForeignCArray executable created a TApplication without "-b". When $DISPLAY is set, ROOT then starts in graphics mode and tries to open the X display. If the X server rejects the connection, Xlib prints "Authorization required, but no authorization protocol specified" to stderr, which ends up in the compared output and fails the test.
The test only exercises I/O of a CArray, so it doesn't need a TApplication at all.
Fixes this test failure on my system: