Skip to content

chore(node-resolve): remove use of deepmerge dependency due to npm audit noise - #2036

Open
gwynne wants to merge 3 commits into
rollup:masterfrom
gwynne:gwynne-patch-1
Open

gwynne wants to merge 3 commits into
rollup:masterfrom
gwynne:gwynne-patch-1

Conversation

@gwynne

@gwynne gwynne commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Rollup Plugin Name: node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

As a result of the bogus advisory GHSA-gcqx-w48m-w2h4, npm audit now reports "2 low security vulnerabilities" due to the deepmerge dependency used by the node-resolve plugin. The upstream maintainer has stated they will not be releasing a fix, as there is no actual vulnerability. However, since the only use of deepmerge by node-resolve is a single invocation which can be easily handled manually, my suggested solution, as implemented in this PR, is to take the opportunity to reduce the plugin's dependency count.

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; the lockfile mismatch is fixed.

Reviews (3) · Last reviewed commit: "update pnpm-lock.yaml hopefully correctl..." · Reviewed by Greptile

Comment thread pnpm-lock.yaml
Comment thread packages/node-resolve/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant