fix(frontend): enforce dns-safe cluster names in byoc create form - #5718
Merged
abcxff merged 2 commits intoSep 14, 2026
Conversation
Contributor
Author
|
Stack for rivet-dev/actors
Get stack: change kzpvtoyp |
railway-app
Bot
temporarily deployed
to
rivet-frontend / actors-pr-5718
September 14, 2026 19:24
Destroyed
Contributor
ReviewSmall, focused fix. Verified how it's wired end-to-end:
Notes (non-blocking)
Overall: correct, minimal, and consistent with the codebase's naming conventions. No security or performance concerns for a client-side regex validator. |
This was referenced Sep 14, 2026
…deletes Port of the workflows-repo fix. Add batchDelete to the EngineDriver interface and all implementations, and route loop-history pruning through runDeletes(), which coalesces keys into transaction-sized (MAX_KV_BATCH_ENTRIES) batchDelete chunks run in bounded rounds (MAX_CONCURRENT_DELETES=64). Previously deleteEntriesWithPrefix / flush fanned out one unbounded Promise.all of single-statement deletes per key; cutting a loop history of >128 entries exceeded the actor SQLite transaction coordinator's 128-permit admission cap (non-blocking try_acquire -> transaction_queue_full).
abcxff
force-pushed
the
stack/fix-frontend-enforce-dns-safe-cluster-names-in-byoc-create-form-kzpvtoyp
branch
from
September 14, 2026 20:45
a7fa909 to
6535fde
Compare
abcxff
force-pushed
the
stack/fix-workflow-engine-clear-pruned-loop-history-via-batched-bounded-deletes-nrzuuryv
branch
from
September 14, 2026 20:45
d2604f9 to
7a3397b
Compare
railway-app
Bot
temporarily deployed
to
rivet-frontend / actors-pr-5718
September 14, 2026 20:45
Destroyed
abcxff
changed the base branch from
stack/fix-workflow-engine-clear-pruned-loop-history-via-batched-bounded-deletes-nrzuuryv
to
main
September 14, 2026 20:45
abcxff
deleted the
stack/fix-frontend-enforce-dns-safe-cluster-names-in-byoc-create-form-kzpvtoyp
branch
September 14, 2026 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.