Repository navigation
pystack: Add version 1.7.2 - #2486
Open
riseproject-dev[bot] wants to merge 2 commits into
Open
riseproject-dev[bot] wants to merge 2 commits into
riseproject-dev[bot] wants to merge 2 commits into
Conversation
Signed-off-by: riseproject-dev[bot] <330740410+riseproject-dev[bot]@users.noreply.github.com>
Contributor
|
luhenry
force-pushed
the
main
branch
3 times, most recently
from
October 1, 2026 15:22
39fb7ba to
a75cf68
Compare
test_stack_of_thread_in_signal_handler[python] and ..._for_core[python], added upstream in 1.7.2 (bloomberg/pystack#348), fail on riscv64 on every tested interpreter (3.12/3.13/3.14/3.14t alike). The fix those tests exercise, build_scripts/elfutils-aarch64-signal-frame.patch, only teaches elfutils' AArch64 backend to unwind through the Linux rt_sigreturn trampoline and recover the interrupted frame from the kernel's rt_sigframe. elfutils ships no equivalent backend for riscv64 at all, so the native unwind stops at the trampoline and never reaches the interrupted CPython eval-loop frame: native_frames ends at __vdso_rt_sigreturn/signalReadinessThenBlock/pause, no frame is ever classified NativeFrame.FrameType.EVAL, and `assert eval_frames` fails with `assert []` identically across all four interpreters. This is the same class of gap as gotcha 616, just arch-gated instead of version-gated, so it needs an unconditional deselect rather than the version-conditional one already in this workflow. Writing a riscv64 unwind backend for elfutils from scratch, with no riscv64 hardware here to validate it against, is not something to carry as a speculative patch, so deselect both tests like upstream already does for x86-64 Alpine via ALL_PYTHONS_BUT_XFAIL_ON_ALPINE. Also fixes a stale "gotcha 597" comment left over from a prior renumbering; the actual entry is gotcha 616.
luhenry
added a commit
that referenced
this pull request
Oct 10, 2026
Follow-up to gotcha 616: the same missing-elfutils-riscv64-unwind-backend class of gap recurs in pystack 1.7.2's new signal-frame-unwind tests, but arch-gated (every interpreter) rather than version-gated (3.13+ only), as hit while triaging build-pystack.yml's test failures on PR #2486.
luhenry
marked this pull request as ready for review
October 11, 2026 01:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated by the nightly
check_versions.pyrun.pystack v1.7.1 -> v1.7.2
Every
- version:entry added todocs/packages/pystack.yamlis built by this PR's ownbuild-pystack.ymlrun; merging publishes the wheels.