Repository navigation
Save the access-key config file readable only by its owner - #76
Closed
revopushbot wants to merge 1 commit into
Closed
revopushbot wants to merge 1 commit into
revopushbot wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing without merging: we're keeping the config file permissions as they are, so customer setups don't change behaviour unexpectedly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of the final clean-up (REV-144): a security fix.
Problem
~/.revopush.configholds the access key, but it was written with default permissions (usually644), so any other user on the machine could read it.Fix
In
script/auth/connection.ts:600, readable and writable only by the owner.Tests
test/connection.tscovers a new file, saving over a644file, and reading a644file. It's skipped on Windows, where file modes don't apply.644explicitly, so a strict umask can't make them pass without the fix. All three fail onmain.configFilePathis exported, so the tests check the same file the code writes.Verification
mainrevopush loginagainst a fake server, new config file644600644file, then any command (whoami)644600tsc, lint and format are clean.Known edge cases (from review, not handled)
sudo -Elogins: if someone logged in withsudo -E, the file belongs to root. It used to stay readable by the normal user; now it is600, so that user has to log in again without sudo.🤖 Generated with Claude Code