Repository navigation
Remove duplicated release, upload and zip code; fix iOS release without --podFile - #73
Merged
Merged
Conversation
…ut --podFile Duplication (no behaviour change): - release-react and release-expo share releaseReactBundle(); the parser shares their options and createCommand case - One release metadata builder for react/expo and native releases - management-sdk release and releaseNative share uploadPackage() - One createZip() in utils/file-utils for the SDK and binary-utils Fix: getIosHermesEnabled crashed when the parser passed podFile: null, which every iOS release-react/release-expo without --podFile does. The release-react test helper now uses the parser's null defaults, so the existing iOS tests cover it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d of if/else Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ashirman
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of the CLI restructuring (REV-141), plus the urgent fix REV-145.
Fix: iOS release-react / release-expo crashed without
--podFile(REV-145)Every iOS
release-react/release-exporun without--podFilefailed onmain:5bde00dreplacedpodFile || "ios/Podfile"with a default parameter value. Defaults only apply toundefined, and the parser passesnullwhen the option isn't given.mainonly. The published0.0.15predates it.getIosHermesEnabledhandlesnullagain, and a new test passespodFile: null.nulldefaults. The test helper now uses exactly what the parser produces, so five existing iOS tests fail without the fix.undefined-only check. None can receive a parsernull. The two options whoseundefinedmatters (patch --buildNumber, and--xcodeTargetName/--buildConfigurationName) are declared withdefault: undefinedon purpose.Duplication removed (no behaviour change)
release-reactandrelease-expo: onereleaseReactBundle(command, bundler)flow;releaseReact/releaseExpoare one-line wrappers. Only the bundler call and entry-file resolution differ, as before.getReactNativePackageInfo, used by react/expo and native releases.releaseandreleaseNativeshare a privateuploadPackage.releaseNativestill always deletes its zip afterwards, and the two identical error branches are merged.createZipinutils/file-utils.ts, used bymanagement-sdkandbinary-utils.binary-utilsstill skips missing files.addReactReleaseOptions, and both commands share onecreateCommandcase. Each command keeps its own usage text, examples andisValidCommandhandling.Verification against
mainrelease-react/release-expo(every option, invalid combinations,--help)releasewith zip upload/nativereleaseupload--podFilemaincrashes; this branch releases version 1.4.2 read from the Xcode projecttsc,npm run lint(0 problems) andnpm run format:checkare clean.Older issues found during review are tracked in REV-144:
release-expoignores--entryFile..zipin the current folder.🤖 Generated with Claude Code