Repository navigation
Move terminal helpers into ui/ and break imports of command-executor - #71
Merged
Merged
Conversation
- log, confirm, requestAccessKey and the upload progress bar move to script/ui; the two upload progress copies become createUploadProgress() - Helper modules no longer import command-executor; takeHermesBaseBytecode receives the SDK - types.ts becomes types/index.ts - Remove the unused index.ts and the package "main", which pointed to a file that is not published Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ashirman
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of the CLI restructuring (REV-138). There's no behaviour change.
command-executor.tsstays the place where commands run; this PR only moves helpers out of it.Changes
script/ui/for terminal interaction:log.ts:log.prompt.ts:confirmandrequestAccessKey, moved word for word.progress.ts:createUploadProgress(), which replaces the progress-bar code that was duplicated indoReleaseanddoNativeRelease.command-executor:binary-utils,react-native-utilsandutils/hermes-utilsimportlogfromui/log.takeHermesBaseBytecodereceives the SDK as a parameter, typed as the one method it uses (Pick<AccountManager, "getBaseRelease">).cli.tsimportscommand-executornow.script/types.ts→script/types/index.ts, so existing"./types"imports still resolve.command-executornow imports types as"./types"rather than"../script/types".script/index.tsand"main"inpackage.json:"main"pointed to./script/cli.js, which isn't in the published package, sorequire("@revopush/code-push-cli")already failed.index.tswasn't used by anything.revopushcommand ("bin") is unchanged.ui/logandui/promptinstead ofcommand-executor.Verification
tsc,npm run lint(0 problems) andnpm run format:checkare clean.mainand from this branch, run against a local fake server with 45 commands, including y/n prompts and release uploads. Output, exit codes and server requests are identical.revopush --versionandwhoamiwork.Follow-ups
hermes-utils→gradle-utils→react-native-utils→hermes-utils): handled whenreact-native-utilsis split in REV-142.main; it's a small separate fix.bin/test. A"files"field and a clean step before build would fix it.🤖 Generated with Claude Code