[revopushbot]

Brings REV-136 to main. It was reviewed as #65, but that PR was merged into feature/rev-134 after #64 had already landed, so its two commits never reached main. The commits are unchanged.

This only modernises the syntax. Behaviour, output, exit codes, the SDK API and server requests are unchanged. Most of the diff is re-indentation, so Hide whitespace makes it much smaller.

Changes

• command-executor: every command handler, execute() and the four release flows use async/await instead of .then chains.
  • if (await confirm()) { … } replaces the nested confirm chains.
  • try/catch around releaseErrorHandler replaces .catch(...).
  • Promise.all is kept where requests ran in parallel (deployment metrics, deployment history).
  • The no-op .catch(async (err) => { throw err; }) blocks are removed.
• management-sdk: the request methods are async and still resolve null where they did before, which the tests assert.
• sign: jwt.sign is used in its synchronous form, and Promise.reject/Promise.resolve inside the async function become throw/return.
• hash-utils, gradle-utils, binary-utils: the last small chains are converted.
• Kept as new Promise: only wrappers around callback and event APIs (superagent, prompt, child_process, yazl/yauzl, streams), plus getSdk's generic error wrapper.
• Review cleanups:
  • The release size result is typed as nullable again.
  • A buildNumber assignment that did nothing and a redundant source-map check are gone.
  • Comments that only repeated the code are removed.

Validation errors that used to be thrown synchronously now reject. Every caller already awaits these calls, and execute() already ran commands inside a promise, so the CLI prints the same [Error] … with the same exit code.

Verification

• Build and lint: tsc and npm run lint are clean.
• Tests: all 155 pass on macOS and on Linux (Docker, Node 20.19.0).
• End to end: the real CLI binary from main and from this branch, run against a local fake server with 45 commands.
  • Coverage: access keys, apps, collaborators, deployments, history, promote, patch, rollback, sessions, release, login state, cancelled prompts, validation errors, server errors, and a duplicate release with and without --noDuplicateReleaseError.
  • Output and exit codes are identical, apart from Replace Q with native promises #64's intended error for unreadable release folders.
  • The server received identical requests and bodies.
• Code signing: the content hash matches main, and a bad key path gives the same error.

Found during review, not changed here

• Signing a folder twice fails: sign() removes an existing .codepushrelease with rmdir, which only works on folders. Fixed separately in REV-137.
• Duplicated release flows: releaseReact and releaseExpo are near-duplicates and could share one implementation.

🤖 Generated with Claude Code