Skip to content

Use async/await instead of promise chains #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashirman merged 2 commits into from
Oct 15, 2026
Merged

Use async/await instead of promise chains #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7155a8
Use async/await instead of promise chains
revopushbot Oct 15, 2026
98d83a2
Tidy async/await code after review
revopushbot Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/binary-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ async function openIPA(ipaPath: string): Promise<{ files: IpaFile[]; appPrefix:
const files: IpaFile[] = [];
for await (const entry of zipFile.eachEntry()) {
if (entry.fileName.endsWith("/")) continue;
files.push({ path: entry.fileName, buffer: () => zipFile.openReadStreamPromise(entry).then(readStreamToBuffer) });
files.push({ path: entry.fileName, buffer: async () => readStreamToBuffer(await zipFile.openReadStreamPromise(entry)) });
}

const appPrefix = files.map((f) => f.path.match(/^(Payload\/[^/]+\.app)\//)?.[1]).find(Boolean);
Expand Down
Loading
Loading