Repository navigation
Conversation
This was referenced Oct 30, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change documenting and logging the existing HTTP/3 proxy fallback.
No open issues 🎉
What changed in this PR
Makes the Netty client's existing HTTP/3 proxy fallback visible without changing transport behavior or adding HTTP/3 proxy support.
Changes:
- Logs an INFO message once at startup when HTTP3 mode is configured with an HTTPS or SOCKS proxy, explaining the HTTP/1.1-over-TCP fallback.
- Clarifies in the transport-mode Javadoc that HTTP/3 applies to HTTPS requests without an HTTP or SOCKS proxy.
| File | Description |
|---|---|
org.restlet/src/main/java/org/restlet/engine/netty/NettyClientHelper.java |
Adds the startup fallback message and clarifies the HTTP/3 proxy limitation in Javadoc. |
Review effort: Balanced
jlouvel
force-pushed
the
chore/netty-http3-proxy-notice
branch
from
October 31, 2026 06:07
63671c2 to
5654564
Compare
In the HTTP3 transport mode, the Netty client sends the HTTPS requests going through an HTTP or SOCKS proxy over TCP, since proxying QUIC requires CONNECT-UDP (RFC 9298), which Netty doesn't support yet. Log it at startup so that the fallback is visible, and mention SOCKS proxies in the httpClientTransportMode Javadoc. Refs #1572. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jerome Louvel <374450+jlouvel@users.noreply.github.com>
jlouvel
force-pushed
the
feat/netty-socks-proxy
branch
from
October 31, 2026 07:44
1b3068f to
8a20e06
Compare
jlouvel
force-pushed
the
chore/netty-http3-proxy-notice
branch
from
October 31, 2026 07:44
5654564 to
0cb3622
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1572 (doesn't close it). Based on #1579.
In the
HTTP3transport mode, HTTPS requests that go through an HTTP or SOCKS proxy fall back to HTTP/1.1 over TCP. Proxying QUIC needsCONNECT-UDP(RFC 9298, MASQUE), which Netty doesn't support yet. This PR only makes the fallback visible. #1572 stays open to track real support.Changes
NettyClientHelper.start(): when theHTTP3mode is combined with an HTTPS or SOCKS proxy, one INFO message says that HTTP/3 is not used through proxies. It is logged once at startup instead of per request.httpClientTransportModeJavadoc: "without HTTP or SOCKS proxy".No
changes.mdentry for a log line. There's no test either: starting theHTTP3mode needs the native QUIC library.Validation
./mvnw -B -pl org.restlet -P default,test verifyat the top of the stack (this branch, including #1574 to #1579): 2,228 tests passed, 0 failures. JaCoCo checks are met, and SpotBugs reports 8 findings, under the threshold of 9.🤖 Generated with Claude Code