Allow clean with invalid module graphs

[fhammerschmidt]

Summary

rescript clean constructed the build graph before removing generated JavaScript. Duplicate module names or another invalid source state could therefore abort cleanup and leave files behind.

Derive both in-source and out-of-source outputs directly from discovered package source files so cleanup does not require compiler discovery or a valid module graph. This also removes generated lib/es6 and lib/js outputs in the project and its dependencies, including dependencies under node_modules. The progress message lists suffixes from all configured package outputs. Cleaning also removes outputs from every package when non-namespaced dependencies share a module name.

Validation

• make test-rewatch
• An isolated regression builds two non-namespaced dependencies separately, confirms both Foo.mjs outputs exist, then checks root cleanup removes both. It passes with this PR and fails with the previous cleanup implementation, which leaves one output behind.
• The existing invalid-module-graph cleanup regression also passes.
• cargo test --manifest-path rewatch/Cargo.toml
• cargo clippy --manifest-path rewatch/Cargo.toml --all-targets --all-features
• make checkformat

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T13:27:23.416862Z	7795392	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1c1a738fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8640

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8640

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8640

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8640

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8640

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8640

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8640

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8640

commit: 39f1863

[github-actions]

Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8640

[fhammerschmidt]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: a32a29e022

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[fhammerschmidt]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 7795392e21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[cknitt]

🤖 This review was generated by Claude (Claude Code) on behalf of @cknitt.

Verdict: approve with nits. No correctness bugs found. Dropping BuildState/get_compiler_info/parse_packages lets clean work with duplicate module names, mismatched .res/.resi pairs, or a missing bsc. A bad root rescript.json or unresolvable dependencies still fail, as they should. The new test fails on master.

• Also fixes an unmentioned bug: the old code keyed modules by name across packages. With two non-namespaced packages that both have src/Foo.res, only the first package's Foo.mjs was deleted. Iterating per package fixes this; might be worth a test.
• New behaviour not in the changelog (clean.rs:82-96): clean now also deletes out-of-source lib/es6/lib/js outputs, including inside dependencies under node_modules. That's consistent with what the build writes, but the fragment should mention it.
• Cosmetic:
  • suffix_for_print only lists in-source suffixes, so the message says "Cleaning .mjs files" while .out.mjs files are also deleted (with only out-of-source specs it prints an empty suffix list, which predates this PR).
  • Empty lib/es6/... directories are left behind after out-of-source cleanup.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.51%. Comparing base (8d51b9c) to head (39f1863).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8640      +/-   ##
==========================================
+ Coverage   80.40%   80.51%   +0.10%     
==========================================
  Files         447      447              
  Lines       60990    61060      +70     
==========================================
+ Hits        49042    49162     +120     
+ Misses      11948    11898      -50     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fhammerschmidt]

Added the cross-package regression in 39f186351: it builds two non-namespaced dependencies with Foo.res, verifies both outputs exist, and checks root cleanup removes both. It fails with the previous implementation, which leaves one output behind. The changelog now mentions out-of-source dependency outputs, and progress messages include all configured suffixes. Directory pruning remains a separate cosmetic follow-up. DCO now passes.