Repository navigation
fix: share guide and playground compiler helpers - #1441
Open
fhammerschmidt wants to merge 1 commit into
Open
fhammerschmidt wants to merge 1 commit into
fhammerschmidt wants to merge 1 commit into
Conversation
Centralize version comparison, runtime import collection and mapping, console messages, and compiler endpoint configuration. Sort numeric version components correctly and preserve the guide compiler pin from rescript-lang#1439. Add regression coverage for both runtime transforms, iframe serialization, metadata failures, endpoint overrides, and multi-digit compiler versions. Fixes rescript-lang#1407. Part of rescript-lang#1421.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fhammerschmidt
added a commit
to fhammerschmidt/rescript-lang.org
that referenced
this pull request
Oct 9, 2026
Use common compiler endpoint configuration and console serialization so the guide compiler pin and lesson validator stay compatible with the playground refactor in rescript-lang#1441. Keep this PR independently buildable before rescript-lang#1441 is merged. Fixes rescript-lang#1405. Part of rescript-lang#1421.
fhammerschmidt
added a commit
to fhammerschmidt/rescript-lang.org
that referenced
this pull request
Oct 9, 2026
Keep validation failures fatal while allowing the shared compiler loader refactor in rescript-lang#1441 to merge cleanly. Part of rescript-lang#1421.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide and playground maintained separate version filters, runtime import collectors and URL mappings, console handlers, and compiler endpoint configuration. Their behavior had diverged, and the playground's digit-concatenation sort could put
v12.9.0ahead ofv12.10.0..mjsto.jsCDN mapping.nulllogs and ignore malformed or unrelated messages./tryloader safe for Cloudflare runtime SSR, preserve production same-origin bundles and endpoint overrides, and check metadata HTTP failures.Targets website
master(v12), onfix/1421-playground-shared. No compiler repository changes.Validation:
Fixes #1407.
Part of #1421.