Repository navigation
fix: clean up guide deployment assets and configuration - #1440
Open
fhammerschmidt wants to merge 2 commits into
Open
fhammerschmidt wants to merge 2 commits into
fhammerschmidt wants to merge 2 commits into
Conversation
Serve the guide public directory so robots.txt reaches the deployed Worker. Import shared favicon assets through Vite and verify robots and icon responses in the Wrangler CI smoke check. Remove the unused build/client-to-out copy and stale TODO checklist. Document the actual deployment directory and keep outstanding launch work in the README. Fixes rescript-lang#1406. Part of rescript-lang#1421.
The guide root and route outputs are tracked compiler files. Keep their compiler formatting authoritative instead of requiring hand-formatting after compilation.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jderochervlk
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide generated an unused
out/copy even though Wrangler servesbuild/client/. Vite's public directory pointed at the docs favicons, so the guide's ownpublic/robots.txtwas omitted from deployment. A separate TODO file duplicated the README launch checklist and contained stale items.buildEndcopy and its filesystem import.public/directory sorobots.txtis served and published.robots.txtand each emitted icon, comparing the response bytes with the expected files. This catches an HTML SPA fallback masquerading as an asset response.TODO.md, retain the supported-browser/performance decision in the README checklist, and document Wrangler's actual deployment directory.Targets website
master(v12). No compiler repository changes.Validation:
out/.robots.txtmatches the guide's source file; all three icon URLs in prerendered HTML resolve to emitted files matching the shared source images.Fixes #1406.
Part of #1421.