Repository navigation
fix: wait for runtime output before completing guide checkpoints - #1437
Open
fhammerschmidt wants to merge 2 commits into
Open
fhammerschmidt wants to merge 2 commits into
fhammerschmidt wants to merge 2 commits into
Conversation
Start every lesson with empty output instead of pre-completing the first checkpoint. Cover compiler loading and failure, iframe output, saved progress, and nonmatching output. Arrange navigation tests with explicit progress and isolate their storage. Fixes rescript-lang#1403 Part of rescript-lang#1421.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Match the API v8 configuration shape and setters used during compiler setup so checkpoint regressions reach compilation and iframe execution.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lesson 1 prefilled the output with
hello, world!, so a fresh visit completed and saved the checkpoint before the compiler loaded. Tests that rendered no compiler also relied on this output.Start every lesson with empty output and remove the first-lesson special case when navigating. The checkpoint now waits for matching runtime output; saved progress still enables navigation on later visits.
Add browser regressions for a missing or loading compiler, failed compiler loading, compilation failure, matching iframe output and saved progress, and nonmatching output. Compiler responses are controlled at the CDN boundary; the compiler manager, bridge, runtime transform, and iframe run normally. Navigation tests arrange saved progress explicitly, clear browser storage between tests, and use MemoryRouter for history navigation.
Targets website
master(v12). No compiler repository changes.Validation:
Fixes #1403.
Part of #1421.