test: add homepage performance checks - #1355
Draft
jderochervlk wants to merge 22 commits into
Draft
jderochervlk wants to merge 22 commits into
jderochervlk wants to merge 22 commits into
Conversation
jderochervlk
force-pushed
the
test/homepage-performance-guardrails
branch
from
September 18, 2026 11:36
74bc6c1 to
75eb72c
Compare
jderochervlk
added this pull request to stack #1357
September 18, 2026 11:53
jderochervlk
removed this pull request from stack #1357
September 18, 2026 12:03
jderochervlk
added this pull request to stack #1359
September 18, 2026 12:03
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
Lighthouse baselineNo Lighthouse baseline is available for target branch
Download the full Lighthouse reports and baseline Commit |
Add production Playwright coverage for prerendering, hydration, navigation, clipboard behavior, and image loading. Track initial asset, DOM, and media baselines in CI before the homepage optimization stack changes them.
Align the Playwright container and deterministic homepage budgets with the React Router, Vite, and Playwright versions now on master.
Run the production prerender build on the standard Ubuntu runner and install Chromium explicitly, avoiding the React Router temporary-server failure inside the Playwright job container.
Run Lighthouse three times against the exact Cloudflare Pages deployment URL and enforce conservative category and Core Web Vitals baselines. Upload the generated reports as workflow artifacts for inspection.
Persist a branch-scoped Lighthouse baseline with the full reports, restore it on the next deployment, and publish a sticky PR comparison comment with a direct artifact link. Cancel stale branch deploys and remove superseded artifacts so each branch retains one current baseline.
Continue collecting and comparing Lighthouse results without failing the performance stack while the homepage optimizations are still in progress.
Restore the Lighthouse artifact for each pull request's base branch instead of the previous artifact from its head branch. Report missing target baselines as N/A so the first stack layer can establish the initial baseline without implying a zero score.
jderochervlk
force-pushed
the
test/homepage-performance-guardrails
branch
from
September 18, 2026 14:11
2b41564 to
44b062f
Compare
Query the pull request API when selecting the Lighthouse target artifact so stacked pull requests compare against their current base branch even when the workflow event payload is stale.
Move branch setup, target baseline restoration, and artifact cleanup out of deploy.yml. Exercise each script through isolated GitHub CLI boundary tests, including API failures and missing baselines. Addresses PR #1355 discussion_r4054814175.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c9d4699f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve prerendering, strict hydration, navigation, image, and real clipboard coverage using the existing Cypress runner. Keep Vitest's Playwright provider unchanged and test the isolated Cypress bootstrap cleanup. Addresses PR #1355 review comment 4054821928.
Re-query the target artifact after download 404/410 responses, with three bounded attempts and N/A when no baseline remains. Preserve all other API and archive failures. Add restore race and failure regression coverage for PR #1355 review comment 4054919822.
jderochervlk
marked this pull request as draft
September 19, 2026 23:02
Split deployment URL setup from Lighthouse baseline metadata and let both checks consume the deployment output directly.
Remove bundle and DOM budgets while retaining measurements and missing-asset checks. Document the limits of the HTML-referenced asset report.
Move the new homepage and Lighthouse tests into a separate Node Vitest configuration without migrating the existing Node script implementations.
Keep the user navigation checks without treating a single opacity value as a route styling contract.
Compile the homepage specs to JSX with typed Cypress bindings and retain prerendering, navigation, image loading, and clipboard assertions.
Replace custom injected-node removal with a stable script slot and a text placeholder. Assert slot usage while continuing to fail on application hydration and console errors.
Compute the stable production or preview URL inside each post-deploy job instead of passing the Wrangler URL through a redacted job output. Keep Lighthouse and Cypress independent after deployment and cover both URL forms in the script tests.
Provide a fake unzip executable in the ReScript workflow fixture and assert the restore script's invocation. This keeps the test focused on the shell contract without requiring unzip in the Vitest Playwright container.
jderochervlk
changed the title
Collaborator
Author
jderochervlk
commented
Sep 20, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f95ba673b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Document the deployment, Cypress server, and Lighthouse helper contracts so their workflow responsibilities are clear.
Keep a readable branch prefix while appending a digest of the full raw name, and cover normalization and truncation collisions.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Establish regression coverage before the homepage performance stack changes component boundaries, images, route payloads, CSS, effects, and compiler behavior. Relates to #1354.
Changes
data-cy-bootstraphydration slot for Cypress startup coordination.mjsscripts in placeExisting slug-only Lighthouse artifacts are not reused. Each target branch will initially show N/A until it publishes its first artifact under the new key; old artifacts expire under their existing retention policy.
Full-stack Lighthouse comparison
Mobile reports for the complete homepage performance stack: