Repository navigation
fix: restore instanceof Text and Comment in replace callback - #2406
Merged
remarkablemark merged 1 commit intoSep 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 136 143 +7
Branches 52 54 +2
=========================================
+ Hits 136 143 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
remarkablemark
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instanceof Elementby resetting prototypes for tag/script/style nodes, but text and comment nodes were left as plain objects.replacecallbacks that checkdomNode instanceof Textstill failed on v6 even with matchingdomhandler/htmlparser2versions.Test plan
npm test(142 tests, 100% coverage)replacecallback:domNode instanceof Textis true for text nodesFixes #2256