Skip to content

chore(dependabot): use directories to cater argocd-operator gomod - #1377

Open
ranakan19 wants to merge 2 commits into
redhat-developer:masterfrom
ranakan19:dependabotfollowup
Open

ranakan19 wants to merge 2 commits into
redhat-developer:masterfrom
ranakan19:dependabotfollowup

Conversation

@ranakan19

Copy link
Copy Markdown
Contributor

What does this PR do?
follow up to #1342,
adds directories to support gomod in sub-module argocd-operator
refer: https://docs.github.com/en/code-security/how-tos/secure-your-supply-chain/manage-your-dependency-security/controlling-dependencies-updated#defining-multiple-locations-for-manifest-files

PR acceptance criteria:
N/A
config changes to dependabot setup

What type of PR is this?
kind chore

Special notes to the reviewer:
discussed in today's operator maintainer meeting

Signed-off-by: Kanika Rana <krana@redhat.com>
@openshift-ci

openshift-ci Bot commented Oct 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olivergondza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from Naveena-058 and svghadi October 12, 2026 15:44
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 3e2cdde4-c154-495c-878c-acc3a3419e7b

📥 Commits

Reviewing files that changed from the base of the PR and between f0608d8 and 3adf687.


📒 Files selected for processing (1)
  • .github/dependabot.yml

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:


Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Chores
    • Automated Go dependency checks now cover both the repository and the Argo CD Operator module on master. Release branches from v1.23 onward use directory-based update configuration. The weekly update schedule remains unchanged.

Walkthrough

The Dependabot configuration adds comments about release-version entries and the argocd-operator integration. The master-branch Go module update entry now monitors / and /argocd-operator.

Changes

Dependabot module coverage

Layer / File(s) Summary
Release guidance and module directories
.github/dependabot.yml
Comments describe keeping release-version entries current and using directories for v1.23-and-later entries. The master-branch Go module update entry now monitors / and /argocd-operator.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 3adf6

Dependabot covers the root module on the configured branches and the nested operator module on master, where it exists. No actionable merge-blocking risk was identified.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the Dependabot configuration change for the argocd-operator Go module.
Description check Passed The description explains that the pull request adds Dependabot directories for the argocd-operator submodule and links to relevant documentation.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


Comment @coderabbitai help to get the list of available commands.

Comment thread .github/dependabot.yml Outdated
directory: "/"
directories:
- "/"
- "/argocd-operator"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note v1.22 does not have argocd-operator/ dir. If dependabot minds, please remove. But if it does not mind missing directory, please add this to all the branches for consistency and the ease of future maintenance.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivergondza done in 3adf687

didn't find docs explicitly mention how dependabot handles missing directory but saw some reported issues which indicate it it fails can impact the PR for valid directories as well. So to be safe, have removed argocd-operator directory and added comments in the file, so we don't forget in future.

Signed-off-by: Kanika Rana <krana@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants