Repository navigation
Conversation
Signed-off-by: Kanika Rana <krana@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to Dependabot covers the root module on the configured branches and the nested operator module on master, where it exists. No actionable merge-blocking risk was identified. Pre-merge checks ·
|
| directory: "/" | ||
| directories: | ||
| - "/" | ||
| - "/argocd-operator" |
There was a problem hiding this comment.
Note v1.22 does not have argocd-operator/ dir. If dependabot minds, please remove. But if it does not mind missing directory, please add this to all the branches for consistency and the ease of future maintenance.
There was a problem hiding this comment.
@olivergondza done in 3adf687
didn't find docs explicitly mention how dependabot handles missing directory but saw some reported issues which indicate it it fails can impact the PR for valid directories as well. So to be safe, have removed argocd-operator directory and added comments in the file, so we don't forget in future.
Signed-off-by: Kanika Rana <krana@redhat.com>
What does this PR do?
follow up to #1342,
adds directories to support gomod in sub-module argocd-operator
refer: https://docs.github.com/en/code-security/how-tos/secure-your-supply-chain/manage-your-dependency-security/controlling-dependencies-updated#defining-multiple-locations-for-manifest-files
PR acceptance criteria:
N/A
config changes to dependabot setup
What type of PR is this?
kind chore
Special notes to the reviewer:
discussed in today's operator maintainer meeting