Skip to content

chore(deps): bump argocd from 3.5.2 to 3.5.4 and image updater from 1.3.0 to 1.3.1 - #1348

Open
chengfang wants to merge 3 commits into
redhat-developer:v1.22from
chengfang:v1.22.ImageUpdater.1.3.1
Open

chore(deps): bump argocd from 3.5.2 to 3.5.4 and image updater from 1.3.0 to 1.3.1#1348
chengfang wants to merge 3 commits into
redhat-developer:v1.22from
chengfang:v1.22.ImageUpdater.1.3.1

Conversation

@chengfang

@chengfang chengfang commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

upgrade image updater and argocd versions for GitOps 1.22.2
Image Updater 1.3.1: https://github.com/argoproj-labs/argocd-image-updater/releases/tag/v1.3.1

PR acceptance criteria:

  • Documentation was updated and verified using make serve-docs
  • Unit tests were updated
  • E2E tests were updated

What type of PR is this?
/kind enhancement

Special notes to the reviewer:

@chengfang
chore(deps): bump argocd from 3.5.2 to 3.5.4 and image updater from 1…
2b26c0e 
….3.0 to 1.3.1

Signed-off-by: Cheng Fang <cfang@redhat.com>
@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Oct 8, 2026
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a672a75b-c3f1-444e-876e-cc12e97a3110

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jannfis and keithchong October 8, 2026 20:07
@svghadi

svghadi commented Oct 9, 2026

Copy link
Copy Markdown
Member

/retest
/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Oct 9, 2026
@openshift-ci

openshift-ci Bot commented Oct 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Oct 9, 2026
@svghadi

svghadi commented Oct 11, 2026

Copy link
Copy Markdown
Member

/retest

7 similar comments
@svghadi

svghadi commented Oct 11, 2026

Copy link
Copy Markdown
Member

/retest

@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@varshab1210

varshab1210 commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@svghadi
Bump argocd operator commit
2fc5c8c 
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@openshift-ci openshift-ci Bot removed the lgtm label Oct 12, 2026
@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

Pushed a commit to include latest argocd-operator release-0.20 reference for fixes.

@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 12, 2026
@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@svghadi @claude
fix(e2e): handle PROMOTER_EXTENSION_IMAGE override in 1-134 test
c9ef404 
On OCP CI the operator subscription sets PROMOTER_EXTENSION_IMAGE to a
registry.redhat.io image, which the operator uses instead of the default
quay.io image and omits the EXTENSION_URL env var. The test hardcoded
both expectations to the defaults, causing it to fail in CI.

Now the test reads PROMOTER_EXTENSION_IMAGE from the operator subscription
or deployment and falls back to the default; the EXTENSION_URL env check
is skipped when the image was overridden, matching the operator's logic.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the lgtm label Oct 12, 2026
@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 12, 2026
@svghadi

svghadi commented Oct 12, 2026

Copy link
Copy Markdown
Member

/retest

@openshift-ci

openshift-ci Bot commented Oct 12, 2026

Copy link
Copy Markdown

@chengfang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.22-kuttl-sequential 2b26c0e link true /test v4.22-kuttl-sequential
ci/prow/v4.22-kuttl-parallel c9ef404 link true /test v4.22-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jannfis jannfis Awaiting requested review from jannfis
@keithchong keithchong Awaiting requested review from keithchong

Assignees

@svghadi svghadi

Labels

approved kind/enhancement New feature or request lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chengfang @svghadi @varshab1210