Repository navigation
Conversation
Signed-off-by: Kanika Rana <krana@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/lgtm |
Signed-off-by: Kanika Rana <krana@redhat.com>
| Controller: getArgoControllerSpec(), | ||
| SSO: getArgoSSOSpec(client), | ||
| Grafana: getArgoGrafanaSpec(), | ||
| Grafana: getArgoGrafanaSpec(), //nolint:staticcheck // SA1019: We must set the deprecated field for backward compatibility. |
There was a problem hiding this comment.
to resolve:
golangci-lint run --new-from-rev=master
controllers/argocd/argocd.go:249:4: SA1019: (github.com/argoproj-labs/argocd-operator/api/v1beta1.ArgoCDSpec).Grafana is deprecated: Grafana defines the Grafana server options for ArgoCD. (staticcheck)
Grafana: getArgoGrafanaSpec(),
|
|
||
| By("creating ImageUpdater CR") | ||
| updateStrategy := "semver" | ||
| namespace := ns.Name |
There was a problem hiding this comment.
to resolve:
test/openshift/e2e/ginkgo/parallel/1-121_validate_image_updater_test.go:172:6: SA1019: (github.com/argoproj-labs/argocd-image-updater/api/v1alpha1.ImageUpdaterSpec).Namespace is deprecated: This field is deprecated and will be removed in a future release. The controller now uses the ImageUpdater CR's namespace (metadata.namespace) to determine which namespace to search for applications. This field is ignored. +optional (staticcheck)
Namespace: &namespace,
|
Thanks, Kanika. /lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olivergondza The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest failed due to |
|
/retest |
|
@ranakan19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
fixes https://redhat.atlassian.net/browse/GITOPS-11249
manual cherry pick of #1251 for v1.20
/kind bug
What does this PR do / why we need it:
fixes https://www.cve.org/CVERecord?id=CVE-2026-71556
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: