Skip to content

chore(deps): upgrade go-git to 5.19.2 for v1.20 - #1340

Open
ranakan19 wants to merge 2 commits into
redhat-developer:v1.20from
ranakan19:gogit1.20
Open

ranakan19 wants to merge 2 commits into
redhat-developer:v1.20from
ranakan19:gogit1.20

Conversation

@ranakan19

@ranakan19 ranakan19 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?
fixes https://redhat.atlassian.net/browse/GITOPS-11249
manual cherry pick of #1251 for v1.20

/kind bug

What does this PR do / why we need it:
fixes https://www.cve.org/CVERecord?id=CVE-2026-71556

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Kanika Rana <krana@redhat.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 53756f35-90f2-4398-bb76-1674427aeca0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jannfis and varshab1210 October 6, 2026 14:25
@olivergondza

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

Signed-off-by: Kanika Rana <krana@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label Oct 12, 2026
Controller: getArgoControllerSpec(),
SSO: getArgoSSOSpec(client),
Grafana: getArgoGrafanaSpec(),
Grafana: getArgoGrafanaSpec(), //nolint:staticcheck // SA1019: We must set the deprecated field for backward compatibility.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to resolve:

golangci-lint run --new-from-rev=master      
controllers/argocd/argocd.go:249:4: SA1019: (github.com/argoproj-labs/argocd-operator/api/v1beta1.ArgoCDSpec).Grafana is deprecated: Grafana defines the Grafana server options for ArgoCD. (staticcheck)
                        Grafana:            getArgoGrafanaSpec(),


By("creating ImageUpdater CR")
updateStrategy := "semver"
namespace := ns.Name

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to resolve:

test/openshift/e2e/ginkgo/parallel/1-121_validate_image_updater_test.go:172:6: SA1019: (github.com/argoproj-labs/argocd-image-updater/api/v1alpha1.ImageUpdaterSpec).Namespace is deprecated: This field is deprecated and will be removed in a future release. The controller now uses the ImageUpdater CR's namespace (metadata.namespace) to determine which namespace to search for applications. This field is ignored. +optional (staticcheck)      
                                        Namespace: &namespace,

@olivergondza

Copy link
Copy Markdown
Collaborator

Thanks, Kanika.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Oct 12, 2026
@openshift-ci

openshift-ci Bot commented Oct 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olivergondza
Once this PR has been reviewed and has the lgtm label, please assign anandf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ranakan19

Copy link
Copy Markdown
Contributor Author

/retest

failed due to connect: network is unreachable

@ranakan19

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Oct 12, 2026

Copy link
Copy Markdown

@ranakan19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.21-kuttl-sequential 092a412 link true /test v4.21-kuttl-sequential
ci/prow/v4.21-e2e 092a412 link true /test v4.21-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants