Repository navigation
[TypeDeclaration] Skip private method param called with ArrayAccess arg in StrictArrayParamDimFetchRector - #8648
Merged
TomasVotruba merged 1 commit intoOct 12, 2026
Conversation
…rg in StrictArrayParamDimFetchRector
TomasVotruba
deleted the
fix-9927-strict-array-param-arrayaccess-caller
branch
October 12, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9927
StrictArrayParamDimFetchRectoradded anarraytype hint based on$param[...]dim fetch usage, but an object implementing\ArrayAccessalso supports[]access. When such an object was passed, the addedarraytype caused aTypeError.A private method is only reachable from inside its own class, so all of its callers are visible in the same file. This adds a guard that, for a private method, scans those callers and skips adding
arraywhen any positional argument resolves to anArrayAccessobject type.Public methods are left unchanged, since their callers can live in other files and cannot be fully resolved here.