Repository navigation
Add generic template to same param-return union methods - #799
Merged
Merged
Conversation
…turn union Narrows the return type to the passed node type via @template, or an explicit conditional return type for factory methods that build a new node. Satisfies the new PreferGenericTemplateOnSameUnionTypeRule from symplify/phpstan-rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Satisfies the new
PreferGenericTemplateOnSameUnionTypeRule(symplify/phpstan-rules).Methods that take a
MethodCall|StaticCallparam and return the same union now declare a@templategeneric, so the return type narrows to the passed node type:@return TCall(orTCall|null)@return ($node is MethodCall ? MethodCall : StaticCall), since a plain@templatereturn would not hold for a freshly built nodeNo behavior change - docblocks only.