Repository navigation
Navbar: Learn links to /docs and docs pages no longer crash - #2347
Conversation
…ing .navbar element Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for submitting your pull request! 🙌 We'll review it asap. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, if it's a Video -LEGEND, which helps speed up the review. If you have questions, reach out to LinkedIn. You can see in our Leaderboard in 20 min from now!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
Thanks again for your contribution! 😊 |
github-actions
Bot
added
in-review
|
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. I would be grateful if you can nominate for keeping this opensource project live and running Link to Nominate. Please do star the repo and Keep up the fantastic work! 🚀 |
This branch was successfully deployed
1 participant
Summary
Cannot read properties of null (reading 'clientHeight')because Docusaurus' table of contents highlight reads the height of an element with the classnavbar, which the new navbar did not have. Added an invisible, correctly sized.navbarprobe inside the new nav (CSS beats the legacy global.navbarrules with!important). This is why clicking "GitHub tutorials" and "recode hive docs" in the Learn menu looked broken./docs(like Showcase links to/showcase); the chevron next to it opens the panel. On mobile the Learn group gets a "Learn overview" link.Checked
Build passes. In a browser: Learn label goes to /docs, "recode hive docs" goes to /docs, "GitHub tutorials" goes to /docs/GitHub/intro-github with no crash, and the nav stays 64px.