Repository navigation
Note where the old enhanced query drops references (#760) - #763
Closed
adamjohnwright wants to merge 2 commits into
Closed
adamjohnwright wants to merge 2 commits into
adamjohnwright wants to merge 2 commits into
Conversation
/data/query/enhanced keeps Java's answer byte for byte, including a bare dbId for an object written earlier; since graph-core bb5e0ca0 an event's parent pathways come first, so references its parent also cites are bare numbers in its own list. Production's browser loses them (#760). The endpoint and the event model now say to read an event's lists from /enhanced/v2, as the details pages do, so the new site does not copy the fault. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eferences too v2 writes each object once as well, with @id, and points back with @ref; it is safe only through the site's JSOGDeserializer, which the note now says. Neighbouring events, not only parent pathways, come before an event's lists in v1. The two v1 readers still at risk are issue #762. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by the next PR: the difference is includeRef, not the version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds comments only, so the new site doesn't copy the fault behind #760. It replaces #761 after that PR's review.
The fault:
/ContentService/data/query/enhanced/{id}(v1) is kept byte for byte as Java answers it.literatureReference.The note goes on the node endpoint and the site's
Eventmodel. It says to read an event's lists from/enhanced/v2through the site'sJSOGDeserializer, as the details pages do. v2 also writes each object once, with@id, and points back to it with{"@ref": …}. The deserializer resolves those references, so v2 is safe only through it.Changed from #761: that PR said v2 writes every object in full, which is wrong; reading v2 raw would lose the same references. It also blamed only the parent pathways.
Two site readers still read v1 lists (the IDG panel's summation, and the entity popup's components). They are issue #762.
No behaviour changes.
Refs #760, #762.
🤖 Generated with Claude Code